From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5762C433DF for ; Thu, 23 Jul 2020 13:08:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7AFA3207BB for ; Thu, 23 Jul 2020 13:08:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="O6QxqRsr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AFA3207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 012B76B0005; Thu, 23 Jul 2020 09:08:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F05A66B0007; Thu, 23 Jul 2020 09:08:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF67B6B0008; Thu, 23 Jul 2020 09:08:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0232.hostedemail.com [216.40.44.232]) by kanga.kvack.org (Postfix) with ESMTP id CC2766B0005 for ; Thu, 23 Jul 2020 09:08:42 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 43A06B782 for ; Thu, 23 Jul 2020 13:08:42 +0000 (UTC) X-FDA: 77069370084.06.hour27_5611fc626f3e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id E9E3410039249 for ; Thu, 23 Jul 2020 13:08:39 +0000 (UTC) X-HE-Tag: hour27_5611fc626f3e X-Filterd-Recvd-Size: 6561 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Thu, 23 Jul 2020 13:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1595509719; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=dXHSH9wbRdiIIVrdpu3/5eZAN762+wcXGXoVK0/kVTw=; b=O6QxqRsrK52mUknxTsz3WiVyT6l6yDgQ/NRsyi75b4IKfrfU7zDEEVq6 btCcFQXSP5KRnPkwY0Gwy662fYC9rk+4DT4LjjbZh3i8guC5pW6HbpawP yi/jvn8DhU+ucxCAfcz6qqgTwzgPPv/aFC+AHuSCcttxlxi8hpHDLWaJW A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: c1OsWBvLwJGdBIFnV7ENKa2QZlNdSh82WqwRMgsvuKPvhFpo8s2BP9yFpIzMwzmrLh1F/8swoZ NrSBwknuSpeGkYXCW5UWNYuhJU8cn0wmYFemgCYDsDgCReb6KpvhYi2bXcfZWWYgtFxE9Ixuvw u9IPUuf+bT+bpZ2TKC6xY9VT1lQpDIyTN64WgIb0KSU+YiyW5pIPd8v9ABo8y0wCjBDXZ82BsE MvH9H5V+C1VWlj2yILkGrJQv49MC+ckfofs7CZwF7xjTb5eCuU3E4AhWScvQVHySkwkSS5GKV4 Oxk= X-SBRS: 2.7 X-MesageID: 23230214 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,386,1589256000"; d="scan'208";a="23230214" Date: Thu, 23 Jul 2020 15:08:31 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= CC: David Hildenbrand , , Boris Ostrovsky , Stefano Stabellini , Andrew Morton , , Subject: Re: [PATCH 3/3] memory: introduce an option to force onlining of hotplug memory Message-ID: <20200723130831.GE7191@Air-de-Roger> References: <20200723084523.42109-1-roger.pau@citrix.com> <20200723084523.42109-4-roger.pau@citrix.com> <21490d49-b2cf-a398-0609-8010bdb0b004@redhat.com> <20200723122300.GD7191@Air-de-Roger> <404ea76f-c3d8-dbc5-432d-08d84a17f2d7@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <404ea76f-c3d8-dbc5-432d-08d84a17f2d7@suse.com> X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-Rspamd-Queue-Id: E9E3410039249 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 23, 2020 at 02:28:13PM +0200, J=C3=BCrgen Gro=C3=9F wrote: > On 23.07.20 14:23, Roger Pau Monn=C3=A9 wrote: > > On Thu, Jul 23, 2020 at 01:37:03PM +0200, David Hildenbrand wrote: > > > On 23.07.20 10:45, Roger Pau Monne wrote: > > > > Add an extra option to add_memory_resource that overrides the mem= ory > > > > hotplug online behavior in order to force onlining of memory from > > > > add_memory_resource unconditionally. > > > >=20 > > > > This is required for the Xen balloon driver, that must run the > > > > online page callback in order to correctly process the newly adde= d > > > > memory region, note this is an unpopulated region that is used by= Linux > > > > to either hotplug RAM or to map foreign pages from other domains,= and > > > > hence memory hotplug when running on Xen can be used even without= the > > > > user explicitly requesting it, as part of the normal operations o= f the > > > > OS when attempting to map memory from a different domain. > > > >=20 > > > > Setting a different default value of memhp_default_online_type wh= en > > > > attaching the balloon driver is not a robust solution, as the use= r (or > > > > distro init scripts) could still change it and thus break the Xen > > > > balloon driver. > > >=20 > > > I think we discussed this a couple of times before (even triggered = by my > > > request), and this is responsibility of user space to configure. Us= ually > > > distros have udev rules to online memory automatically. Especially,= user > > > space should eb able to configure *how* to online memory. > >=20 > > Note (as per the commit message) that in the specific case I'm > > referring to the memory hotplugged by the Xen balloon driver will be > > an unpopulated range to be used internally by certain Xen subsystems, > > like the xen-blkback or the privcmd drivers. The addition of such > > blocks of (unpopulated) memory can happen without the user explicitly > > requesting it, and hence not even aware such hotplug process is takin= g > > place. To be clear: no actual RAM will be added to the system. > >=20 > > Failure to online such blocks using the Xen specific online handler > > (which does not handle back the memory to the allocator in any way) > > will result in the system getting stuck and malfunctioning. > >=20 > > > It's the admin/distro responsibility to configure this properly. In= case > > > this doesn't happen (or as you say, users change it), bad luck. > > >=20 > > > E.g., virtio-mem takes care to not add more memory in case it is no= t > > > getting onlined. I remember hyper-v has similar code to at least wa= it a > > > bit for memory to get onlined. > >=20 > > I don't think VirtIO or Hyper-V use the hotplug system in the same wa= y > > as Xen, as said this is done to add unpopulated memory regions that > > will be used to map foreign memory (from other domains) by Xen driver= s > > on the system. > >=20 > > Maybe this should somehow use a different mechanism to hotplug such > > empty memory blocks? I don't mind doing this differently, but I would > > need some pointers. Allowing user-space to change a (seemingly > > unrelated) parameter and as a result produce failures on Xen drivers > > is not an acceptable solution IMO. >=20 > Maybe we can use the same approach as Xen PV-domains: pre-allocate a > region in the memory map to be used for mapping foreign pages. For the > kernel it will look like pre-ballooned memory, so it will create struct > page for the region (which is what we are after), but it won't give the > memory to the allocator. IMO using something similar to memory hotplug would give us more flexibility, and TBH the logic is already there in the balloon driver. It seems quite wasteful to allocate such region(s) beforehand for all domains, even when most of them won't end up using foreign mappings at all. Anyway, I'm going to take a look at how to do that, I guess it's going to involve playing with the memory map and reserving some space. I suggest we should remove the Xen balloon hotplug logic, as it's not working properly and we don't have a plan to fix it. Thanks, Roger.