From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A016C433E7 for ; Tue, 21 Jul 2020 23:46:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C5AC2206E3 for ; Tue, 21 Jul 2020 23:46:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5AC2206E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 445A76B0003; Tue, 21 Jul 2020 19:46:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F7ED6B0005; Tue, 21 Jul 2020 19:46:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30CD16B0006; Tue, 21 Jul 2020 19:46:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 1E71C6B0003 for ; Tue, 21 Jul 2020 19:46:24 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BA272E30F63B for ; Tue, 21 Jul 2020 23:46:23 +0000 (UTC) X-FDA: 77063719446.20.anger90_3e10cf326f31 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 90A03180ED8A6 for ; Tue, 21 Jul 2020 23:46:23 +0000 (UTC) X-HE-Tag: anger90_3e10cf326f31 X-Filterd-Recvd-Size: 2564 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Jul 2020 23:46:22 +0000 (UTC) IronPort-SDR: RXccnrRSlM/IoJHo9Rl34MES7JWZNGUnkkCcp2WHGUplALVv4is8hHBYLWtT2OBpwiNxsfh6Id Wfz9NAT+o3zw== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="130329722" X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="130329722" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 16:46:20 -0700 IronPort-SDR: EdUSW0Kroy9pLQvPhnmhLmYYOgpMioJiapWH6En2np7t2X2KTiWSzCwIAxA87FRz5khEkSDYCa 3ohxscb2IZ6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="284036759" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by orsmga003.jf.intel.com with ESMTP; 21 Jul 2020 16:46:20 -0700 Date: Tue, 21 Jul 2020 16:46:20 -0700 From: Ira Weiny To: Tang Yizhou Cc: linux-mm@kvack.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH -next] mm/gup.c: Fix the comment of return value for populate_vma_page_range() Message-ID: <20200721234619.GC643353@iweiny-DESK2.sc.intel.com> References: <20200720034303.29920-1-tangyizhou@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200720034303.29920-1-tangyizhou@huawei.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-Rspamd-Queue-Id: 90A03180ED8A6 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 20, 2020 at 11:43:03AM +0800, Tang Yizhou wrote: > The return value of populate_vma_page_range() is consistent with > __get_user_pages(), and so is the function comment of return value. > > Signed-off-by: Tang Yizhou Reviewed-by: Ira Weiny > --- > mm/gup.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 2cc5eba44362..a55f1ec712e9 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1386,7 +1386,8 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm, > * > * This takes care of mlocking the pages too if VM_LOCKED is set. > * > - * return 0 on success, negative error code on error. > + * Return either number of pages pinned in the vma, or a negative error > + * code on error. > * > * vma->vm_mm->mmap_lock must be held. > * > -- > 2.17.1 >