From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 032B7C433E1 for ; Tue, 21 Jul 2020 06:06:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6D9D20B1F for ; Tue, 21 Jul 2020 06:06:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6D9D20B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 02E8F6B0002; Tue, 21 Jul 2020 02:06:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F200F6B0006; Tue, 21 Jul 2020 02:06:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E35898D0001; Tue, 21 Jul 2020 02:06:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id CDFD16B0002 for ; Tue, 21 Jul 2020 02:06:19 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5A4A98248047 for ; Tue, 21 Jul 2020 06:06:19 +0000 (UTC) X-FDA: 77061048078.30.river60_1e06b9d26f2b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 3C22118020624 for ; Tue, 21 Jul 2020 06:06:19 +0000 (UTC) X-HE-Tag: river60_1e06b9d26f2b X-Filterd-Recvd-Size: 3677 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Jul 2020 06:06:18 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id j18so1571211wmi.3 for ; Mon, 20 Jul 2020 23:06:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GEJvDmDqn6sLqFGmbMAPYT4gvGGjecP1Sm9qiSzvSg4=; b=pEZmR8SWW8fGTV7Q2CGYCN29fUyLrS8T4xynsJxvXERP0nHkqf5i7OKr0MH64T8MQP u4UcXkrzjtZM9n8LbSm5+FLorNvPozyYvqp4uYPFrpR+cJc/Lqdsvv1QBHFrE+wAONCf xpyXGGiC0G47wamb48/lkxgr2qfRpwZtMDmAlJeFfb655dittOoajRCad5318DhKvdFE WjLdpDYwf+wWh4Iky49EOXHJ+RLpXitVoJH57bCwq+b6MUxMsiUqOoiWgmMPiLTB1G4o bmrGgDJew2vh95qK6h7/57NrYAZ6MHbkw75WK9hFNVP2nVmdAfmF6YlxYMMRjvpEbaV5 +9Wg== X-Gm-Message-State: AOAM53249Oy1gU3Rk8a3/qyT0T5gEabqAjltOnpw9bTqb3qI4MDk28b2 z4MwhXjIB324wBRUucMI3Cc= X-Google-Smtp-Source: ABdhPJx3ZIKKHylHi/Ud9vTnKq5gaDz7bqKChgA0SQjKooIW1UxHLGwS09fRhoKuMDf9S6GoWswnhg== X-Received: by 2002:a1c:3102:: with SMTP id x2mr2559625wmx.171.1595311577741; Mon, 20 Jul 2020 23:06:17 -0700 (PDT) Received: from localhost (ip-37-188-169-187.eurotel.cz. [37.188.169.187]) by smtp.gmail.com with ESMTPSA id a11sm12833297wrq.0.2020.07.20.23.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 23:06:16 -0700 (PDT) Date: Tue, 21 Jul 2020 08:06:15 +0200 From: Michal Hocko To: Yafang Shao Cc: rientjes@google.com, penguin-kernel@i-love.sakura.ne.jp, akpm@linux-foundation.org, cai@lca.pw, linux-mm@kvack.org Subject: Re: [PATCH v2] mm, oom: show process exiting information in __oom_kill_process() Message-ID: <20200721060615.GF4061@dhcp22.suse.cz> References: <20200721010127.17238-1-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721010127.17238-1-laoar.shao@gmail.com> X-Rspamd-Queue-Id: 3C22118020624 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 20-07-20 21:01:27, Yafang Shao wrote: > When the OOM killer finding a victim and trying to kill it, if the victim > is already exiting, the task mm will be NULL and no process will be killed. > But the dump_header() has been already executed, so it will be strange to > dump so many information without killing a process. We'd better show some > helpful information to indicate why this happens. > > Suggested-by: David Rientjes > Signed-off-by: Yafang Shao > Cc: Michal Hocko > Cc: Tetsuo Handa > Cc: Qian Cai Acked-by: Michal Hocko Thanks! > --- > v1 -> v2: > - improve the output, per Tetsuo and Michal > --- > mm/oom_kill.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 6e94962893ee..c176c988c109 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -863,6 +863,8 @@ static void __oom_kill_process(struct task_struct *victim, const char *message) > > p = find_lock_task_mm(victim); > if (!p) { > + pr_info("%s: OOM victim %d (%s) is already exiting. Skip killing the task\n", > + message, task_pid_nr(victim), victim->comm); > put_task_struct(victim); > return; > } else if (victim != p) { > -- > 2.18.1 -- Michal Hocko SUSE Labs