From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B746C2BC0E for ; Mon, 20 Jul 2020 21:39:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 62DEE22BF5 for ; Mon, 20 Jul 2020 21:39:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62DEE22BF5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=libc.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B739B6B0003; Mon, 20 Jul 2020 17:39:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B235B6B0008; Mon, 20 Jul 2020 17:39:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A12366B000A; Mon, 20 Jul 2020 17:39:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 88FF66B0003 for ; Mon, 20 Jul 2020 17:39:19 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 30CAF8248D7C for ; Mon, 20 Jul 2020 21:39:19 +0000 (UTC) X-FDA: 77059770438.28.legs08_500e6b326f28 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id F3DD9899A44E for ; Mon, 20 Jul 2020 21:39:18 +0000 (UTC) X-HE-Tag: legs08_500e6b326f28 X-Filterd-Recvd-Size: 3041 Received: from brightrain.aerifal.cx (brightrain.aerifal.cx [216.12.86.13]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jul 2020 21:39:17 +0000 (UTC) Date: Mon, 20 Jul 2020 17:39:13 -0400 From: Rich Felker To: David Hildenbrand Cc: Jia He , Catalin Marinas , Will Deacon , Tony Luck , Fenghua Yu , Yoshinori Sato , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , Baoquan He , Chuhong Yuan , Mike Rapoport , Logan Gunthorpe , Masahiro Yamada , Michal Hocko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-nvdimm@lists.01.org, linux-mm@kvack.org, Jonathan Cameron , Kaly Xin Subject: Re: [PATCH v3 3/6] sh/mm: use default dummy memory_add_physaddr_to_nid() Message-ID: <20200720213913.GM14669@brightrain.aerifal.cx> References: <20200709020629.91671-1-justin.he@arm.com> <20200709020629.91671-4-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Rspamd-Queue-Id: F3DD9899A44E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 09, 2020 at 11:10:36AM +0200, David Hildenbrand wrote: > On 09.07.20 04:06, Jia He wrote: > > After making default memory_add_physaddr_to_nid in mm/memory_hotplug, > > there is no use to define a similar one in arch specific directory. > > > > Signed-off-by: Jia He > > --- > > arch/sh/mm/init.c | 9 --------- > > 1 file changed, 9 deletions(-) > > > > diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c > > index a70ba0fdd0b3..f75932ba87a6 100644 > > --- a/arch/sh/mm/init.c > > +++ b/arch/sh/mm/init.c > > @@ -430,15 +430,6 @@ int arch_add_memory(int nid, u64 start, u64 size, > > return ret; > > } > > > > -#ifdef CONFIG_NUMA > > -int memory_add_physaddr_to_nid(u64 addr) > > -{ > > - /* Node 0 for now.. */ > > - return 0; > > -} > > -EXPORT_SYMBOL_GPL(memory_add_physaddr_to_nid); > > -#endif > > - > > void arch_remove_memory(int nid, u64 start, u64 size, > > struct vmem_altmap *altmap) > > { > > > > Reviewed-by: David Hildenbrand Acked-by: Rich Felker