From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51693C433E6 for ; Mon, 20 Jul 2020 09:08:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 11B122080D for ; Mon, 20 Jul 2020 09:08:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="HxkaKcaN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11B122080D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 75D806B0003; Mon, 20 Jul 2020 05:08:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70F256B0005; Mon, 20 Jul 2020 05:08:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FC1A6B0006; Mon, 20 Jul 2020 05:08:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id 473A06B0003 for ; Mon, 20 Jul 2020 05:08:28 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C3417230AA6 for ; Mon, 20 Jul 2020 09:08:27 +0000 (UTC) X-FDA: 77057878254.10.queen87_170105f26f23 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 9551D21AEC5 for ; Mon, 20 Jul 2020 09:08:27 +0000 (UTC) X-HE-Tag: queen87_170105f26f23 X-Filterd-Recvd-Size: 6643 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jul 2020 09:08:27 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id h19so19363981ljg.13 for ; Mon, 20 Jul 2020 02:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Sh4MS3jUQIDrJLd4vHFPdZZzioXde4EYbE1HOPlh13U=; b=HxkaKcaN9yT2V7ZbAje7mzcMt/z6ba8T1u+k3mhy7wc0R6NzOoX+e2SOu89cEy0t9G nxR/Uf4XRe7rYBwENYitIi81YRTrMri/Ek7LRwQxg5chHBQsXwnTn269HZgi7dUptGje ARy/c/1/26H0oqgs5V1LTsU7ptGY2gzSrPrQQhK7ILynxD+PBzB8UlEyTJjfHKDHBQXN SmT89qTrR23UT9QaZ1JYGpS5Wxn6e0xyjZkzo8xDo2x/ehnyZHZ/bYNrd5THVvDjNjpE s6lyEEv8WcDjfaSh4RDNhFg1SOC2qyOi8BLgqG+/jNPV060oPMDOyJp+8sq2NYp2wPQx yWWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Sh4MS3jUQIDrJLd4vHFPdZZzioXde4EYbE1HOPlh13U=; b=rxlGHcZ0rKhApou51ZuV4O5BG2Udm2WAdM1OngsBiqAJW9n0zEYSg8rFrKKyncjSqy rEtRWem06hJ8qdFEihlI2bjyN4N5415EdD3ZwoNb7XSJbcdJseSgaWd/WVfGRanvb/QK G4k7Iumqp4YrmTIR3VDTPHsIH0Y8xN4Rvm9nrN1aBVsOB54gbZw3a8nQ8jvDWjQQigeO +bXHKjx40WTrnWy2NYITBmd2VvWSm2HKSozfuiQiZOvP94+m+BzkzoCI7I5Vqx1a1iLP D56kiW+/KYdpu+iB2wLiuT70EmnkBWHht6LpflSvwBaVgNVkhYz/Ifu65BRzo9yqNZap G5EQ== X-Gm-Message-State: AOAM5300wRMPqyGgMDLp1PDiVKp1KZHPn4ib8EHMjsZj+QHl5CBNQipB PrNhsPUyfb5HhRgSpT0eZwBDfg== X-Google-Smtp-Source: ABdhPJz8cpXNQtuNgua8Q/5kP+FMbyffG/YjFwU9hrEck7Rn4UUhQj4nSis1VJgGu6O/8JzycIR6SQ== X-Received: by 2002:a2e:961a:: with SMTP id v26mr10549143ljh.467.1595236105719; Mon, 20 Jul 2020 02:08:25 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id b11sm3661070lfa.50.2020.07.20.02.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 02:08:25 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 09F0F102393; Mon, 20 Jul 2020 12:08:25 +0300 (+03) Date: Mon, 20 Jul 2020 12:08:24 +0300 From: "Kirill A. Shutemov" To: Hillf Danton Cc: syzbot , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Song Liu , "Kirill A . Shutemov" , syzkaller-bugs@googlegroups.com, Markus Elfring Subject: Re: general protection fault in khugepaged Message-ID: <20200720090824.gjg4bay2pnnurasm@box> References: <000000000000358aec05a9fc8aa8@google.com> <20200718085409.1448-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200718085409.1448-1-hdanton@sina.com> X-Rspamd-Queue-Id: 9551D21AEC5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.010808, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 18, 2020 at 04:54:09PM +0800, Hillf Danton wrote: > > Wed, 08 Jul 2020 23:43:19 -0700 > > syzbot found the following crash on: > > > > HEAD commit: e44f65fd xen-netfront: remove redundant assignment to vari.. > > git tree: net-next > > console output: https://syzkaller.appspot.com/x/log.txt?x=15de54a7100000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=829871134ca5e230 > > dashboard link: https://syzkaller.appspot.com/bug?extid=ed318e8b790ca72c5ad0 > > compiler: gcc (GCC) 10.1.0-syz 20200507 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=113406a7100000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=175597d3100000 > > > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > > Reported-by: syzbot+ed318e8b790ca72c5ad0@syzkaller.appspotmail.com > > > > general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN > > KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] > > CPU: 1 PID: 1155 Comm: khugepaged Not tainted 5.8.0-rc2-syzkaller #0 > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > > RIP: 0010:anon_vma_lock_write include/linux/rmap.h:120 [inline] > > RIP: 0010:collapse_huge_page mm/khugepaged.c:1110 [inline] > > RIP: 0010:khugepaged_scan_pmd mm/khugepaged.c:1349 [inline] > > RIP: 0010:khugepaged_scan_mm_slot mm/khugepaged.c:2110 [inline] > > RIP: 0010:khugepaged_do_scan mm/khugepaged.c:2193 [inline] > > RIP: 0010:khugepaged+0x3bba/0x5a10 mm/khugepaged.c:2238 > > Code: 01 00 00 48 8d bb 88 00 00 00 48 89 f8 48 c1 e8 03 42 80 3c 30 00 0f 85 fa 0f 00 00 48 8b 9b 88 00 00 00 48 89 d8 48 c1 e8 03 <42> 80 3c 30 00 0f 85 d4 0f 00 00 48 8b 3b 48 83 c7 08 e8 9f ff 30 > > RSP: 0018:ffffc90004be7c80 EFLAGS: 00010246 > > RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff81a72d8b > > RDX: ffff8880a69d8100 RSI: ffffffff81b7606b RDI: ffff88809f0577c0 > > RBP: 0000000000000000 R08: 0000000000000000 R09: ffff8881ff213a7f > > R10: 0000000000000080 R11: 0000000000000000 R12: ffffffff8aae6110 > > R13: ffffc90004be7de0 R14: dffffc0000000000 R15: 0000000020000000 > > FS: 0000000000000000(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000 > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > CR2: 0000000000000000 CR3: 00000001fe0cf000 CR4: 00000000001406e0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > kthread+0x3b5/0x4a0 kernel/kthread.c:291 > > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293 > > Fixes: 99cb0dbd47a1 ("mm,thp: add read-only THP support for (non-shmem) FS") It looks sane, but I think it's easier to check in hugepage_vma_revalidate(). Something like this (untested): diff --git a/mm/khugepaged.c b/mm/khugepaged.c index b043c40a21d4..700f5160f3e4 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -958,6 +958,9 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, return SCAN_ADDRESS_RANGE; if (!hugepage_vma_check(vma, vma->vm_flags)) return SCAN_VMA_CHECK; + /* Anon VMA expected */ + if (!vma->anon_vma || vma->vm_ops) + return SCAN_VMA_CHECK; return 0; } -- Kirill A. Shutemov