From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF6AFC433E5 for ; Sun, 19 Jul 2020 04:41:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E2242073A for ; Sun, 19 Jul 2020 04:41:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E2242073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 040CF6B0003; Sun, 19 Jul 2020 00:41:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F330A6B0005; Sun, 19 Jul 2020 00:41:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E21AA6B0008; Sun, 19 Jul 2020 00:41:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id CA2136B0003 for ; Sun, 19 Jul 2020 00:41:39 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 28CBA8248047 for ; Sun, 19 Jul 2020 04:41:39 +0000 (UTC) X-FDA: 77053577118.12.care84_5a04e0926f19 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id E0480180F7994 for ; Sun, 19 Jul 2020 04:41:38 +0000 (UTC) X-HE-Tag: care84_5a04e0926f19 X-Filterd-Recvd-Size: 2855 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Jul 2020 04:41:37 +0000 (UTC) IronPort-SDR: GoHge3K0aBVxeXhUhyJ9bjfmZyhwwBJ/OUFY5BHZCrP8PXOzsyFwXnLniyJzwqKi/7gtmrbZpl N81FYG8omxoA== X-IronPort-AV: E=McAfee;i="6000,8403,9686"; a="147284925" X-IronPort-AV: E=Sophos;i="5.75,369,1589266800"; d="scan'208";a="147284925" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2020 21:41:36 -0700 IronPort-SDR: 0R5r0POrAHJZkIVzaYM5LvL14m/HsDRcbVdHTM0jGjiiFzLf4uCpR3LN64DWY7R6h6P5xz5WOU AavFLGXR8NLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,369,1589266800"; d="scan'208";a="269852530" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by fmsmga007.fm.intel.com with ESMTP; 18 Jul 2020 21:41:36 -0700 Date: Sat, 18 Jul 2020 21:41:36 -0700 From: Ira Weiny To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Andy Lutomirski , x86@kernel.org, Dave Hansen , Dan Williams , Vishal Verma , Andrew Morton , Fenghua Yu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH RFC V2 14/17] dax: Stray write protection for dax_direct_access() Message-ID: <20200719044135.GB478573@iweiny-DESK2.sc.intel.com> References: <20200717072056.73134-1-ira.weiny@intel.com> <20200717072056.73134-15-ira.weiny@intel.com> <20200717092243.GD10769@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717092243.GD10769@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.11.1 (2018-12-01) X-Rspamd-Queue-Id: E0480180F7994 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 17, 2020 at 11:22:43AM +0200, Peter Zijlstra wrote: > On Fri, Jul 17, 2020 at 12:20:53AM -0700, ira.weiny@intel.com wrote: > > > --- a/drivers/dax/super.c > > +++ b/drivers/dax/super.c > > @@ -30,12 +30,14 @@ static DEFINE_SPINLOCK(dax_host_lock); > > > > int dax_read_lock(void) > > { > > + dev_access_enable(); > > return srcu_read_lock(&dax_srcu); > > } > > EXPORT_SYMBOL_GPL(dax_read_lock); > > > > void dax_read_unlock(int id) > > { > > + dev_access_disable(); > > srcu_read_unlock(&dax_srcu, id); > > } > > EXPORT_SYMBOL_GPL(dax_read_unlock); > > This is inconsistently ordered. Thanks, good catch. Fixed. Ira