From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DADDC433DF for ; Sat, 18 Jul 2020 17:25:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 238CF2073A for ; Sat, 18 Jul 2020 17:25:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GWIQWpSx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 238CF2073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 66D8B8D0001; Sat, 18 Jul 2020 13:25:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61DED6B0005; Sat, 18 Jul 2020 13:25:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50E5F8D0001; Sat, 18 Jul 2020 13:25:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 36FAF6B0003 for ; Sat, 18 Jul 2020 13:25:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id ADF7724389 for ; Sat, 18 Jul 2020 17:25:24 +0000 (UTC) X-FDA: 77051872968.29.verse31_3e132aa26f15 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 11C6918064A49 for ; Sat, 18 Jul 2020 17:24:52 +0000 (UTC) X-HE-Tag: verse31_3e132aa26f15 X-Filterd-Recvd-Size: 7320 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Sat, 18 Jul 2020 17:24:51 +0000 (UTC) Received: by mail-pj1-f67.google.com with SMTP id f16so7839037pjt.0 for ; Sat, 18 Jul 2020 10:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iCm2YtXH023pz1F7fKyIw7mxMySdID8uzb2LgkkHspE=; b=GWIQWpSx/gXpm4+29AvUW9eiPQ+/bRdxbw27V8hPqrw5tlmrv+HzIQE/VmfmBAv6zB B3CI9b8nv/s9i95x82s+QBLvNBBRCnAon3Q3DkK2mnqrvmO1GZqS2QGM+5QAnB3QXEga XEUiP1kbW1sI36lb9+Yp/9tBF2nN3OVRSxceRRFYFJ5Z+T2rTj+ApLMQWBJ8hg8/kyq1 fFhWtAw6iFj9UKnWqSvD28GCvTI1MU8gkL8KvtnwTTCQPkOd0pBrw3qkq4jU1lyf3qDs pPsl4vWDcuDmWebotIVU39nia5PdmQfICUZV3u/32c7SXoiRaXU/9qwWVuVk3prul59+ M0/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=iCm2YtXH023pz1F7fKyIw7mxMySdID8uzb2LgkkHspE=; b=YpMAGVnZlWuLGsKAOSNQAyNv7iRkCsIhK5stxQ2qQ1DVUCZbwK4enPYg7DiMVo+7HH 466Xm63+L5GpFwkGWi8YyV/WRJzneDpaIJI07anYI8P3LRhz0ZueXrJiphOxe1YMgHED VUa/ah3HX2Ys1+eL+N031dj/NdLS6AzHGhO1GmN0K1fDAgk5BxnbWrBwYV80hNtozZN6 cN1dHBWnlTN1f6lN9KUzmf3KtYuX8Zt4A5ZnSxp/1mzTzszIP3WvliENqoUqQezeZ8a2 hrZK/OJdqLBpSvCBeRIPRAv2ArvlzI0rHslMXNvVo3uieyp6per2hFo339bJlED0xZJ6 T1kw== X-Gm-Message-State: AOAM531Vr8Y+dMe1bUNNNt0XurJf/0IXNPYSgW9vviR3mauVbOrH3k5U Ch+RkIuL3xEYmTHdqQZ1Nn4= X-Google-Smtp-Source: ABdhPJwuy41SbHQ1FpBg+wbrIZOW4OWZmRXhSq1sgPl5lPAxEa2yWQybDC+9aZgF3MGapHKIBxZP9A== X-Received: by 2002:a17:902:b682:: with SMTP id c2mr11609572pls.273.1595093090529; Sat, 18 Jul 2020 10:24:50 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id u26sm11252251pfn.54.2020.07.18.10.24.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 18 Jul 2020 10:24:50 -0700 (PDT) Date: Sat, 18 Jul 2020 10:24:49 -0700 From: Guenter Roeck To: Roman Gushchin Cc: Andrew Morton , Christoph Lameter , Johannes Weiner , Michal Hocko , Shakeel Butt , linux-mm@kvack.org, Vlastimil Babka , kernel-team@fb.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 17/19] mm: memcg/slab: use a single set of kmem_caches for all allocations Message-ID: <20200718172449.GA48060@roeck-us.net> References: <20200623174037.3951353-1-guro@fb.com> <20200623174037.3951353-18-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200623174037.3951353-18-guro@fb.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 11C6918064A49 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000114, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 23, 2020 at 10:40:35AM -0700, Roman Gushchin wrote: > Instead of having two sets of kmem_caches: one for system-wide and > non-accounted allocations and the second one shared by all accounted > allocations, we can use just one. > > The idea is simple: space for obj_cgroup metadata can be allocated on > demand and filled only for accounted allocations. > > It allows to remove a bunch of code which is required to handle kmem_cache > clones for accounted allocations. There is no more need to create them, > accumulate statistics, propagate attributes, etc. It's a quite > significant simplification. > > Also, because the total number of slab_caches is reduced almost twice (not > all kmem_caches have a memcg clone), some additional memory savings are > expected. On my devvm it additionally saves about 3.5% of slab memory. > > Suggested-by: Johannes Weiner > Signed-off-by: Roman Gushchin > Reviewed-by: Vlastimil Babka > Reviewed-by: Shakeel Butt This patch results in: {standard input}: Assembler messages: {standard input}:140: Warning: macro instruction expanded into multiple instructions mm/slub.c: In function 'slab_alloc.constprop': mm/slub.c:2897:30: error: inlining failed in call to always_inline 'slab_alloc.constprop': recursive inlining static __always_inline void *slab_alloc(struct kmem_cache *s, and many similar messages when trying to build mips:64r6el_defconfig or mips:defconfig. Bisect log attached. Guenter --- # bad: [aab7ee9f8ff0110bfcd594b33dc33748dc1baf46] Add linux-next specific files for 20200717 # good: [11ba468877bb23f28956a35e896356252d63c983] Linux 5.8-rc5 git bisect start 'HEAD' 'v5.8-rc5' # good: [4d55a7a1298d197755c1a0f4512f56917e938a83] Merge remote-tracking branch 'crypto/master' git bisect good 4d55a7a1298d197755c1a0f4512f56917e938a83 # good: [e63bf5dcce255302e355cb2277a3a39c83752c92] Merge remote-tracking branch 'devicetree/for-next' git bisect good e63bf5dcce255302e355cb2277a3a39c83752c92 # good: [94d932ec3afb923efd8c736974f8316413175a5b] Merge remote-tracking branch 'thunderbolt/next' git bisect good 94d932ec3afb923efd8c736974f8316413175a5b # good: [5ddd2e0dbe8fceb80b0b36bd38a32217be7a04a5] Merge remote-tracking branch 'livepatching/for-next' git bisect good 5ddd2e0dbe8fceb80b0b36bd38a32217be7a04a5 # bad: [40346f79983caf46fb92f779b0353422d43580a9] ipc/shm.c: Remove the superfluous break git bisect bad 40346f79983caf46fb92f779b0353422d43580a9 # bad: [0b917599517f71ddef5f7274a8199a33cecd49b2] kasan: update required compiler versions in documentation git bisect bad 0b917599517f71ddef5f7274a8199a33cecd49b2 # good: [7822c5f77725d5bf4ea48f155b0aa3827db19423] tmpfs: per-superblock i_ino support git bisect good 7822c5f77725d5bf4ea48f155b0aa3827db19423 # bad: [c5b15b89803e3ed2810be285def5f4836e5ee629] mm, memcg: reclaim more aggressively before high allocator throttling git bisect bad c5b15b89803e3ed2810be285def5f4836e5ee629 # good: [2b6d98a0b0cb5ff828228c6a094813c4919727da] mm: memcg/slab: remove redundant check in memcg_accumulate_slabinfo() git bisect good 2b6d98a0b0cb5ff828228c6a094813c4919727da # bad: [d32b702628530c68b4147d410b4cdf21610e9f93] mm: memcg/percpu: per-memcg percpu memory statistics git bisect bad d32b702628530c68b4147d410b4cdf21610e9f93 # bad: [b109396be9be1b8fd91fa4c70bd73a0e93722274] percpu: return number of released bytes from pcpu_free_area() git bisect bad b109396be9be1b8fd91fa4c70bd73a0e93722274 # bad: [6cee58aca5d334ee8195a711e4eb61a05e5f7eb5] kselftests: cgroup: add kernel memory accounting tests git bisect bad 6cee58aca5d334ee8195a711e4eb61a05e5f7eb5 # bad: [2528f5d4f3c139035dc3adcbfb6c63ca14c840f0] mm: memcg/slab: use a single set of kmem_caches for all allocations git bisect bad 2528f5d4f3c139035dc3adcbfb6c63ca14c840f0 # first bad commit: [2528f5d4f3c139035dc3adcbfb6c63ca14c840f0] mm: memcg/slab: use a single set of kmem_caches for all allocations