From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB58C433E0 for ; Thu, 16 Jul 2020 08:46:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FC3B20775 for ; Thu, 16 Jul 2020 08:46:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="Ycw6kDBx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FC3B20775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1C9E56B0007; Thu, 16 Jul 2020 04:46:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17AB86B000C; Thu, 16 Jul 2020 04:46:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 044588D0001; Thu, 16 Jul 2020 04:46:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id DF2316B0007 for ; Thu, 16 Jul 2020 04:46:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 533A282499B9 for ; Thu, 16 Jul 2020 08:46:48 +0000 (UTC) X-FDA: 77043308496.27.art73_0a051f126f00 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 2BBC53D663 for ; Thu, 16 Jul 2020 08:46:48 +0000 (UTC) X-HE-Tag: art73_0a051f126f00 X-Filterd-Recvd-Size: 5104 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jul 2020 08:46:47 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id t9so2858605lfl.5 for ; Thu, 16 Jul 2020 01:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bCC4Mo9K3VF01NtlTfFZEG+9hWwFt1H0Qp6ndqIsiwU=; b=Ycw6kDBxvy+1hQHj8/FEH/4U7ljQ25EreUCaL8gvHBx79vA4SVG7pi1ofaKXig142P Gv4HHcbCIl7RuiW+f6NYdmQ18/KM9+d6WPB3wsltKZM/LHLdCq4EyEaSjSy2kASMEmNd UButTqENhwLwFBBan8sW2USiTgE6HsycZxDMUEqXEhq1hNS1IFzcUxBQ/SHQ/4nSdMC8 ol/m2fyHdFtlPPWvoYWBOenk3RLLYvhDA6+nd+VPnVB+gzGDVHFcJZz6wXcsevOmmK7j TG9IlfdqD3qQ+cxBN7CkGBrTKDah/jOIKq8qc3Ty8euWFfetsHaS5lGuEBZvSo5NzgEg A08A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bCC4Mo9K3VF01NtlTfFZEG+9hWwFt1H0Qp6ndqIsiwU=; b=KUnLv6zpJCFYJGiv40PPutdR22iXp6iMqA+Anh9maCoeJXXQcZOPAzlJbDZC/cdpTp vCdh46NIyZD21iGcUyOU+A5tLL3mBH6DzubSCzrvmu2f8+GfQvaPnQoKehvbbDmO4Sy0 BRkT45dU6XCqP8o9/jN4/jrSguEZPa5OWjKCe6wp+f2EMHce0XMWIq4tVADHG5xix3Hp JENV8vIDiflzLREIqHM7/3xmy/IZxrAcr4JsozdnMo6JeC/r3GNDglx20brwG+cMW0Dx w55qC10vuh2bb9vMDwcxDrmu1AFPLyKqNdwmr5yTZnqMSOiRK3Xk+bPg9XH3n7Hi5UdR HYdA== X-Gm-Message-State: AOAM531gaHJTmrMj1ehmbjVNCdhc8PVCUet2Xhc9jN2zr0YZPifUEhZa 9GYHvIKjpv1o4gqk86YqtbdHvn7/4xo= X-Google-Smtp-Source: ABdhPJz8inNJN8d4cqC6GtP6eT65CJ32H8/x2tA708d+Q20Njn2roHvF8GceCd/xwIpo0KKI8jOrAg== X-Received: by 2002:a19:4a96:: with SMTP id x144mr1571683lfa.213.1594889206222; Thu, 16 Jul 2020 01:46:46 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id y188sm1242637lfc.36.2020.07.16.01.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 01:46:45 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id B0BE91020FF; Thu, 16 Jul 2020 11:46:51 +0300 (+03) Date: Thu, 16 Jul 2020 11:46:51 +0300 From: "Kirill A. Shutemov" To: Naresh Kamboju Cc: Linus Torvalds , Joel Fernandes , "Kirill A. Shutemov" , Andrew Morton , Linux-MM , Linux Kernel Mailing List , William Kucharski Subject: Re: [PATCHv2] mm: Fix warning in move_normal_pmd() Message-ID: <20200716084651.4457czjaszv3uprv@box> References: <20200715205428.GA201569@google.com> <20200715222228.jf2pv5u2wyhtc5o5@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2BBC53D663 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 16, 2020 at 12:53:23PM +0530, Naresh Kamboju wrote: > On Thu, 16 Jul 2020 at 12:07, Naresh Kamboju wrote: > > > > On Thu, 16 Jul 2020 at 04:49, Linus Torvalds > > wrote: > > > > > > On Wed, Jul 15, 2020 at 4:04 PM Linus Torvalds > > > wrote: > > > > > > > > It *might* be as simple as this incremental thing on top > > > > > > No, it needs to be > > > > > > + if (*old_addr + *len < old->vm_end) > > > + return; > > > > > > in try_to_align_end(), of course. > > > > > > Now I'm going for a lie-down, because this cross-eyed thing isn't working. > > > > > > Just want to double check. > > Here is the diff after those two patches applied. Please correct me if > > it is wrong. > > This patch applied on top of Linus mainline master branch. > > I am starting my test cycles. > > Sorry this patch (the below pasted ) did not solve the reported problem. As Linus said, it does not trigger on the stack movement anymore and it is not going to fix the issue, but may help to increase coverage of the optimization. -- Kirill A. Shutemov