From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA35C433E3 for ; Wed, 15 Jul 2020 21:13:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5AAF920672 for ; Wed, 15 Jul 2020 21:13:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="mrXN+dy1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AAF920672 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BD07C6B0002; Wed, 15 Jul 2020 17:13:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B81136B0005; Wed, 15 Jul 2020 17:13:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A96EF6B0006; Wed, 15 Jul 2020 17:13:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id 93A726B0002 for ; Wed, 15 Jul 2020 17:13:15 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0A6E8181AC9BF for ; Wed, 15 Jul 2020 21:13:15 +0000 (UTC) X-FDA: 77041560750.22.park94_14145db26efc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 2EA7D18038E67 for ; Wed, 15 Jul 2020 21:13:14 +0000 (UTC) X-HE-Tag: park94_14145db26efc X-Filterd-Recvd-Size: 3757 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jul 2020 21:13:13 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id d17so4359872ljl.3 for ; Wed, 15 Jul 2020 14:13:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=40EEju4zhqJNrLfahZyvepUCR8xy5Lu2ucbT1r8p0F0=; b=mrXN+dy1yUMmabC3DbDw1XiQjq2v4RTo4FewptRgSRsKZaezXTLKzGQsdD2IK2Lw4o ylOOtZ9Wku93bV570PsOKqjeYOQyiBgg2w9hC6iZALlL8Oz3scyc3iSz2QJDTU7drBQX nN44CCsIqw7tc9YR/DGGT/hQ7jDupBu42eszm91Mo9plmbHtq9/v8ZtkKb4r+TGVZK/s 9qTUQ1K9texzP7W8vFwC+tbJfkMpl0Rl+QBhHahf9RnHxtN3jATVi3rH//8aL73Pa7pZ my87Wq2fK5ApE2hvH7buO2uLfaGZ7xlEukhxstbwuCCM/6kwsmdpzh5Dk0GXNqtn3Vxw 30PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=40EEju4zhqJNrLfahZyvepUCR8xy5Lu2ucbT1r8p0F0=; b=pEu/U2T3Hb3lFmwDfJc9D4t8Uc7bPgjVW2Lu0E+GnXfpih0RSjBbgKyvsFQmklTrNV 7Ly5ucvqx6ak/Xrh2t8qf8PwsDH7Gk3w0erxRxn/x9MjQ74aq6ibTfaH6UIsVsa4z+6W uUgM0T2Fuu97EIPpv286FvCYf3bJU4M3wS8ERXZz4AHmqy1XfXbvoYgbfu3V2wLVx3hC wmA4PbWF/XUBEDRJ97La2cpxk/ubshD8qtfuYl9Gr5G4XKtRINugukshCn9gka23FYsh 8VsvyGNdlzlhPJDKf13YeSMUYAtN27/kG0PeWS0uZUK19ZYVR0PAgSHjJ3lD3ERCi+Ab rTkA== X-Gm-Message-State: AOAM530PklIGyMF1Dfcyozs4UilJYi4rKpD5t3Qr2J1oJomrKXR2hXVK pd/bn1D/EANkwu7ZH4oSywx94w== X-Google-Smtp-Source: ABdhPJxUsPALjvyqqoh3klOIbksCl3fNYezR8nEYz/TKInS5zb4Btyj6cdvMN2tAyk/SnqE3Qd7sEQ== X-Received: by 2002:a2e:9dc6:: with SMTP id x6mr441174ljj.94.1594847592248; Wed, 15 Jul 2020 14:13:12 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id u25sm791726lju.54.2020.07.15.14.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 14:13:11 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id E10BE102143; Thu, 16 Jul 2020 00:13:17 +0300 (+03) Date: Thu, 16 Jul 2020 00:13:17 +0300 From: "Kirill A. Shutemov" To: Joel Fernandes Cc: Linus Torvalds , "Kirill A. Shutemov" , Andrew Morton , Linux-MM , Linux Kernel Mailing List , Naresh Kamboju , William Kucharski Subject: Re: [PATCHv2] mm: Fix warning in move_normal_pmd() Message-ID: <20200715211317.hxw724qajn7ksioo@box> References: <20200715135011.42743-1-kirill.shutemov@linux.intel.com> <20200715205428.GA201569@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200715205428.GA201569@google.com> X-Rspamd-Queue-Id: 2EA7D18038E67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 15, 2020 at 04:54:28PM -0400, Joel Fernandes wrote: > Hi Linus, > > On Wed, Jul 15, 2020 at 11:36:59AM -0700, Linus Torvalds wrote: > Regarding the ADDR_AFTER_NEXT checks, shouldn't you check for: > > if (ADDR_AFTER_NEXT(ALIGN(*old_addr + *len, PMD_SIZE), old)) > return; See comment to ADDR_AFTER_NEXT(). -- Kirill A. Shutemov