From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68DD8C433E5 for ; Wed, 15 Jul 2020 12:10:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0C51120771 for ; Wed, 15 Jul 2020 12:10:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C51120771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7939C6B0002; Wed, 15 Jul 2020 08:10:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7438C6B0003; Wed, 15 Jul 2020 08:10:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 632F56B0005; Wed, 15 Jul 2020 08:10:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 4D45C6B0002 for ; Wed, 15 Jul 2020 08:10:31 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CA9631F1A for ; Wed, 15 Jul 2020 12:10:30 +0000 (UTC) X-FDA: 77040193020.05.fly07_150942126ef9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 8B6231801DBD5 for ; Wed, 15 Jul 2020 12:10:30 +0000 (UTC) X-HE-Tag: fly07_150942126ef9 X-Filterd-Recvd-Size: 2503 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jul 2020 12:10:30 +0000 (UTC) Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 860542065D; Wed, 15 Jul 2020 12:10:26 +0000 (UTC) Date: Wed, 15 Jul 2020 13:10:23 +0100 From: Catalin Marinas To: Zhenyu Ye Cc: will@kernel.org, suzuki.poulose@arm.com, maz@kernel.org, steven.price@arm.com, guohanjun@huawei.com, olof@lixom.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arm@kernel.org, xiexiangyou@huawei.com, prime.zeng@hisilicon.com, zhangshaokun@hisilicon.com, kuhn.chenqun@huawei.com Subject: Re: [PATCH v3 2/3] arm64: enable tlbi range instructions Message-ID: <20200715121023.GC2519@gaia> References: <20200715071945.897-1-yezhenyu2@huawei.com> <20200715071945.897-3-yezhenyu2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200715071945.897-3-yezhenyu2@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 8B6231801DBD5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 15, 2020 at 03:19:44PM +0800, Zhenyu Ye wrote: > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile > index a0d94d063fa8..4e823b97c92e 100644 > --- a/arch/arm64/Makefile > +++ b/arch/arm64/Makefile > @@ -82,11 +82,18 @@ endif > # compiler to generate them and consequently to break the single image contract > # we pass it only to the assembler. This option is utilized only in case of non > # integrated assemblers. > +ifneq ($(CONFIG_AS_HAS_ARMV8_4), y) > branch-prot-flags-$(CONFIG_AS_HAS_PAC) += -Wa,-march=armv8.3-a > endif > +endif I couldn't find a clear statement in the gas documentation on what happens if multiple -march options are passed. I think it's safer to avoid this here. > KBUILD_CFLAGS += $(branch-prot-flags-y) > > +ifeq ($(CONFIG_AS_HAS_ARMV8_4), y) > +# make sure to pass the newest target architecture to -march. > +KBUILD_CFLAGS += -Wa,-march=armv8.4-a > +endif I have a suspicion both of these options will break the LLVM integrated assembler but we don't officially support it on arm64 yet (-Wa, doesn't seem to get passed to the integrated asm). Thanks for the re-spin. -- Catalin