From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CFA2C433E6 for ; Wed, 15 Jul 2020 06:36:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C99F520663 for ; Wed, 15 Jul 2020 06:36:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C99F520663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4DAE86B0002; Wed, 15 Jul 2020 02:36:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48AD96B0003; Wed, 15 Jul 2020 02:36:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 379FF6B0005; Wed, 15 Jul 2020 02:36:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 231156B0002 for ; Wed, 15 Jul 2020 02:36:44 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A707B8248D51 for ; Wed, 15 Jul 2020 06:36:43 +0000 (UTC) X-FDA: 77039351886.20.cover76_5d0363426ef7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 714B0180C0609 for ; Wed, 15 Jul 2020 06:36:43 +0000 (UTC) X-HE-Tag: cover76_5d0363426ef7 X-Filterd-Recvd-Size: 3744 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jul 2020 06:36:43 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id q15so4168371wmj.2 for ; Tue, 14 Jul 2020 23:36:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7/7YlCQQS4NfdI2cjoTLRwj8KZpvs8wrGSrY0FMkPh0=; b=I413eOBphk+Metyyrm6JtlOkiMs7Kl8OTAeg2+T2H1e03tRI1/uybDgo9JKiNvJm1z tababGzU/XrfInpHwAND1ssYm16yQx7nOrKHYuLvRnT8WV379EcpNfj4QJjod6ZNznW/ xTbnuTv1svneLzfMYxR5Tk/OgxlK6VBPITQCDX6jSTfhNEMT3gqCVWCj2GzA29f8rLt3 ndb8TFCBJsRAA4C6Xd7s9o7i30MUBvD1Y5dOaBfaIbeV7RhXCTEKHEvmT/2yGtgIPDbs snDKlWBVWRXiR3X3ONHDkM+FvtGjL3r7wq3eF7glPuD5TwmzW2TpblZ841OzVfURjQJj dgtA== X-Gm-Message-State: AOAM5324hkn0nRMZsENAu0RladBXuRM3+9VodXjTKsrUw6bkrnrbZkT9 voJutiSRTCw8VqybiNMHoLw= X-Google-Smtp-Source: ABdhPJzhsPV6nJJtiemGrmFxaPyOMI93M1GFQlk9i6/jxMDh1l1C4XRZG2kXT5m6ORa3FiYsr6xBRg== X-Received: by 2002:a7b:cf18:: with SMTP id l24mr7024055wmg.116.1594795001964; Tue, 14 Jul 2020 23:36:41 -0700 (PDT) Received: from localhost (ip-37-188-169-187.eurotel.cz. [37.188.169.187]) by smtp.gmail.com with ESMTPSA id u16sm1896668wmn.11.2020.07.14.23.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 23:36:41 -0700 (PDT) Date: Wed, 15 Jul 2020 08:36:39 +0200 From: Michal Hocko To: Suren Baghdasaryan Cc: Todd Kjos , Hridya Valsaraju , Hillf Danton , Eric Biggers , syzbot , Andrew Morton , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Christian Brauner , "open list:ANDROID DRIVERS" , Greg Kroah-Hartman , Hugh Dickins , "Joel Fernandes (Google)" , LKML , Linux-MM , Martijn Coenen , syzkaller-bugs , Todd Kjos , Markus Elfring Subject: Re: possible deadlock in shmem_fallocate (4) Message-ID: <20200715063639.GA5451@dhcp22.suse.cz> References: <0000000000000b5f9d059aa2037f@google.com> <20200714033252.8748-1-hdanton@sina.com> <20200714053205.15240-1-hdanton@sina.com> <20200714140859.15156-1-hdanton@sina.com> <20200714141815.GP24642@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 714B0180C0609 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 14-07-20 10:32:20, Suren Baghdasaryan wrote: [...] > I'm not sure how we can annotate the fact that the inode_lock in > generic_file_write_iter and in shmem_fallocate always operate on > different inodes. Ideas? I believe that the standard way is to use lockdep_set_class on your backing inode. But asking lockdep experts would be better than relying on my vague recollection -- Michal Hocko SUSE Labs