From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6692EC433E4 for ; Tue, 14 Jul 2020 20:22:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1690F206F5 for ; Tue, 14 Jul 2020 20:22:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="P8ibvs29" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1690F206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 945D98D0006; Tue, 14 Jul 2020 16:22:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CE798D0001; Tue, 14 Jul 2020 16:22:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76F1D8D0006; Tue, 14 Jul 2020 16:22:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 5CC3A8D0001 for ; Tue, 14 Jul 2020 16:22:37 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C33F1180AD801 for ; Tue, 14 Jul 2020 20:22:36 +0000 (UTC) X-FDA: 77037804312.13.loss67_29132ef26ef3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 8BAC718140B60 for ; Tue, 14 Jul 2020 20:22:36 +0000 (UTC) X-HE-Tag: loss67_29132ef26ef3 X-Filterd-Recvd-Size: 3500 Received: from ozlabs.org (ozlabs.org [203.11.71.1]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jul 2020 20:22:35 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4B5sPy5MrBz9sRK; Wed, 15 Jul 2020 06:22:30 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1594758151; bh=m6q0t5rQ4tSfOmMooV1EHEwUQAHvbpn5mjHL15F+qEw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P8ibvs29lkUkCz49co9V7WPBcFc/Fsw2a7NNDseIh5Z31qyH7nJnsa3KUz/4KcVHh XKaV46mul9bSfayC/SuC0pMo/cIsabqX0Ssqr3ROzYPLYP/gMlHEo/br7IWo1BN1Zx Yak5pqJreqTXZckh2FJxYNYTd1PgBpsFFWkz3fF4DRMinpALDJsfHr8XH3lXBQW+yq kKRPfE4iZoOHBrWBEqnhLj6TPEtQxPK1BqaYzF9HV2JkfbETO8Q2mWN7b2p7gygoAO /VjzTRywXnwW4StfhKJLmi/P4Khyhzd9ZEZO44JBhvzsww+HRXJO3vRdQjut/W7CDU KBdoxrjfvqg8g== Date: Wed, 15 Jul 2020 06:22:29 +1000 From: Stephen Rothwell To: Bixuan Cui Cc: , , , , , Roman Gushchin Subject: Re: [PATCH v2] mm/percpu: fix 'defined but not used' warning Message-ID: <20200715062229.78591ff9@canb.auug.org.au> In-Reply-To: <6f1a8c76-d6d7-1a2c-8b0b-26a4a31f1a19@huawei.com> References: <20200714134101.80534-1-cuibixuan@huawei.com> <20200714225311.7aeffffd@canb.auug.org.au> <6f1a8c76-d6d7-1a2c-8b0b-26a4a31f1a19@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/PLQTjSuhLZHKFG1.u30PGb4"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Rspamd-Queue-Id: 8BAC718140B60 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --Sig_/PLQTjSuhLZHKFG1.u30PGb4 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Bixuan, Thanks for this. On Tue, 14 Jul 2020 21:46:18 +0800 Bixuan Cui wrote: > > Gcc report the following warning without CONFIG_MEMCG_KMEM: >=20 > mm/percpu-internal.h:145:29: warning: 'pcpu_chunk_type' defined > but not used [-Wunused-function] > static enum pcpu_chunk_type pcpu_chunk_type(struct pcpu_chunk *chunk) > ^~~~~~~~~~~~~~~ >=20 > Add 'inline' to pcpu_chunk_type(),pcpu_is_memcg_chunk() and > pcpu_chunk_list() to clear warning. >=20 > Fixes: 26c99879ef01 ("mm: memcg/percpu: account percpu memory to memory c= groups") > Signed-off-by: Stephen Rothwell You really should not add SUB lines for others - in this case a Suggested-by is more appropriate. --=20 Cheers, Stephen Rothwell --Sig_/PLQTjSuhLZHKFG1.u30PGb4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl8OFAUACgkQAVBC80lX 0GwHggf/bNn1uN+FOLwHWa7pt12Gtfv8cZ13520mBvzbvw2hVaoiMGE1xgZuZ6WM 9VYCtJXLpeFWsHJXOZKBI0HxIjJHkDR5rNZ3fnorDexzBJ0LvjTj/GUMjuUHv1vq owAraeXUIsJUDr2jpuRq60+5PUm80F3+YGF35694tl1uHxK8Do/CFM4i7bRz/aQ/ ynfJNm/hFoR9CbBDISULAujfLnhKHgwR2z7fxgqqSM3Uj3hWZZyTI1GfS6oKVsJz XN7UEb95LUCQiCUhsZeU2g4IR/rkXokDwoqDghIEX63zeb5//XJstDKHV7x6Xpgd v49A+51vkMXaLbMI0h4C+gXZAETleA== =IdV1 -----END PGP SIGNATURE----- --Sig_/PLQTjSuhLZHKFG1.u30PGb4--