From: Roman Gushchin <guro@fb.com>
To: Bixuan Cui <cuibixuan@huawei.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
<akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <linux-next@vger.kernel.org>,
<john.wanghui@huawei.com>
Subject: Re: [PATCH v2] mm/percpu: fix 'defined but not used' warning
Date: Tue, 14 Jul 2020 11:41:37 -0700 [thread overview]
Message-ID: <20200714184137.GA491030@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <6f1a8c76-d6d7-1a2c-8b0b-26a4a31f1a19@huawei.com>
On Tue, Jul 14, 2020 at 09:46:18PM +0800, Bixuan Cui wrote:
> Gcc report the following warning without CONFIG_MEMCG_KMEM:
>
> mm/percpu-internal.h:145:29: warning: 'pcpu_chunk_type' defined
> but not used [-Wunused-function]
> static enum pcpu_chunk_type pcpu_chunk_type(struct pcpu_chunk *chunk)
> ^~~~~~~~~~~~~~~
>
> Add 'inline' to pcpu_chunk_type(),pcpu_is_memcg_chunk() and
> pcpu_chunk_list() to clear warning.
Acked-by: Roman Gushchin <guro@fb.com>
Thank you!
>
> Fixes: 26c99879ef01 ("mm: memcg/percpu: account percpu memory to memory cgroups")
The "fixes" tag is not valid: the patch is in the mm queue, so it doesn't
have a stable hash. Usually Andrew squashes such fixes into the original patch
on merging.
Thanks!
next prev parent reply other threads:[~2020-07-14 18:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 13:41 [PATCH] mm/percpu: mark pcpu_chunk_type() as __maybe_unused Bixuan Cui
2020-07-14 12:53 ` Stephen Rothwell
2020-07-14 13:33 ` Bixuan Cui
2020-07-14 13:34 ` [PATCH v2] mm/percpu: fix 'defined but not used' warning Bixuan Cui
2020-07-14 13:45 ` Bixuan Cui
2020-07-14 13:46 ` Bixuan Cui
2020-07-14 18:41 ` Roman Gushchin [this message]
2020-07-15 0:24 ` Bixuan Cui
2020-07-14 20:22 ` Stephen Rothwell
2020-07-15 0:25 ` [PATCH v3] " Bixuan Cui
2020-07-15 1:50 ` Stephen Rothwell
2020-07-15 2:18 ` Bixuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714184137.GA491030@carbon.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=cuibixuan@huawei.com \
--cc=john.wanghui@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox