From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Robbie Ko <robbieko@synology.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-btrfs@vger.kernel.org, Roman Gushchin <guro@fb.com>,
David Sterba <dsterba@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH] mm : fix pte _PAGE_DIRTY bit when fallback migrate page
Date: Tue, 14 Jul 2020 13:19:51 +0300 [thread overview]
Message-ID: <20200714101951.6osakxdgbhrnfrbd@box> (raw)
In-Reply-To: <433e26b0-5201-129a-4afe-4881e42781fa@suse.cz>
On Tue, Jul 14, 2020 at 11:46:12AM +0200, Vlastimil Babka wrote:
> On 7/13/20 3:57 AM, Robbie Ko wrote:
> >
> > Vlastimil Babka 於 2020/7/10 下午11:31 寫道:
> >> On 7/9/20 4:48 AM, robbieko wrote:
> >>> From: Robbie Ko <robbieko@synology.com>
> >>>
> >>> When a migrate page occurs, we first create a migration entry
> >>> to replace the original pte, and then go to fallback_migrate_page
> >>> to execute a writeout if the migratepage is not supported.
> >>>
> >>> In the writeout, we will clear the dirty bit of the page and use
> >>> page_mkclean to clear the dirty bit along with the corresponding pte,
> >>> but page_mkclean does not support migration entry.
I don't follow the scenario.
When we establish migration entries with try_to_unmap(), it transfers
dirty bit from PTE to the page.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2020-07-14 10:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 2:48 robbieko
2020-07-10 15:31 ` Vlastimil Babka
2020-07-13 1:57 ` Robbie Ko
2020-07-14 9:46 ` Vlastimil Babka
2020-07-14 10:19 ` Kirill A. Shutemov [this message]
2020-07-15 2:45 ` Robbie Ko
2020-07-15 8:11 ` Kirill A. Shutemov
2020-07-16 10:15 ` Robbie Ko
2020-07-17 17:41 ` Chris Mason
2020-07-15 2:05 ` Robbie Ko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714101951.6osakxdgbhrnfrbd@box \
--to=kirill@shutemov.name \
--cc=dsterba@suse.com \
--cc=guro@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=robbieko@synology.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox