From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C1BC433E5 for ; Tue, 14 Jul 2020 07:33:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C68B207BB for ; Tue, 14 Jul 2020 07:33:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="Z/wYVQyt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C68B207BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CAF838D0002; Tue, 14 Jul 2020 03:33:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C60368D0001; Tue, 14 Jul 2020 03:33:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4E008D0002; Tue, 14 Jul 2020 03:33:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 9CA0E8D0001 for ; Tue, 14 Jul 2020 03:33:05 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 44A072DFA for ; Tue, 14 Jul 2020 07:33:05 +0000 (UTC) X-FDA: 77035865130.06.wish79_3916c7c26eef Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 17FA71003D074 for ; Tue, 14 Jul 2020 07:33:05 +0000 (UTC) X-HE-Tag: wish79_3916c7c26eef X-Filterd-Recvd-Size: 5747 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jul 2020 07:33:04 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id s9so21266310ljm.11 for ; Tue, 14 Jul 2020 00:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=R8orn93ADt/4gOBW8WREoRLbcPdxazQvh/HwHNIuhAY=; b=Z/wYVQytSqKk3IH73/ux75nV4a9eng7MqAusYNZKDbWAhyRl1DiFjkwYNX42KabOKB j3LZ4sjY4SUzGCaSEKgB9NdJezNz+UehQo+59s/d9nVbH69yfKSQMYKMxi0afnuMg3Vt +jfoqZNsgQaj41KfbjsIM5sF4xL4ubkEvxVTjZGSYtl7M+lcUpBp6Y1ct+JOgW5Ka86O qZqqQD4TEVIWLz+mf6tYW3p/YYliDIrc3FBTgWd4soRSc3/7NRpUNqfaItmM6k8k5quc YETGoX9lodspJ+HWv7iDPcBoK/47UNGi1TP0GGW0VKMxku7BiRKhOsim8gkYmquvtTFS NIlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R8orn93ADt/4gOBW8WREoRLbcPdxazQvh/HwHNIuhAY=; b=lhPWwyotfnnk7x82lTjfRKlmZUQNsqTnwN8IfRpWBqhku/Z2XhTczYiZbmL+9MQCcx qgqdPOZyZsfLaMEq+yMUNZIO2+xrjSS6lFhAT0+tuKL79NzA7lrifS+khq1vkqAzJf3K Z5I5Y0EYtuQ2ikEm1uZBSk3/S0WO9D3Ddnw+US45ZQaMc+QYkExywDVqeqMMm/31lAGr 1y6o775TflJrcF3oMug407EAsrQdGtweGDsq293g3J8sNdPaFwEjFj33zg/i3raMqifV 2RwNbo0FKnbplU9JHXWdTH/mBJUFrTBOJWyKTgqKNHNBChjTfczzmbqgfnAbvGDE2BTj /kug== X-Gm-Message-State: AOAM533Bi1VkXSekEXJbZRWgQCchWnC2hknkkOo5rqqUzvfc9INGT9uI qRs2TpADLfCtM5AYjQtwhsPtBw== X-Google-Smtp-Source: ABdhPJx7Tu4+/eXTMAvrPy+NFt0qJma4hLbxqpf8m1or7AVtlxWHP6cAteAQCMqlnwkRL1E8WUItLw== X-Received: by 2002:a05:651c:3c2:: with SMTP id f2mr1714736ljp.37.1594711982733; Tue, 14 Jul 2020 00:33:02 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id i15sm5093781lfl.57.2020.07.14.00.33.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 00:33:02 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 0F10E101459; Tue, 14 Jul 2020 10:33:06 +0300 (+03) Date: Tue, 14 Jul 2020 10:33:06 +0300 From: "Kirill A. Shutemov" To: Linus Torvalds Cc: Joel Fernandes , Naresh Kamboju , linux- stable , open list , linux-mm , Arnd Bergmann , Andrew Morton , Roman Gushchin , Michal Hocko , lkft-triage@lists.linaro.org, Chris Down , Michel Lespinasse , Fan Yang , Brian Geffon , Anshuman Khandual , Will Deacon , Catalin Marinas , pugaowei@gmail.com, Jerome Glisse , Greg Kroah-Hartman , Mel Gorman , Hugh Dickins , Al Viro , Tejun Heo , Sasha Levin Subject: Re: WARNING: at mm/mremap.c:211 move_page_tables in i386 Message-ID: <20200714073306.kq4zikkphqje2yzb@box> References: <20200712215041.GA3644504@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 17FA71003D074 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 12, 2020 at 03:58:06PM -0700, Linus Torvalds wrote: > Anybody else have any opinions? Maybe we just shouldn't allow move_normal_pmd() if ranges overlap? Other option: pass 'overlaps' down to move_normal_pmd() and only WARN() if see establised PMD without overlaps being true. Untested patch: diff --git a/mm/mremap.c b/mm/mremap.c index 5dd572d57ca9..e33fcee541fe 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -245,6 +245,18 @@ unsigned long move_page_tables(struct vm_area_struct *vma, unsigned long extent, next, old_end; struct mmu_notifier_range range; pmd_t *old_pmd, *new_pmd; + bool overlaps; + + /* + * shift_arg_pages() can call move_page_tables() on overlapping ranges. + * In this case we cannot use move_normal_pmd() because destination pmd + * might be established page table: move_ptes() doesn't free page + * table. + */ + if (old_addr > new_addr) + overlaps = old_addr - new_addr < len; + else + overlaps = new_addr - old_addr < len; old_end = old_addr + len; flush_cache_range(vma, old_addr, old_end); @@ -282,7 +294,7 @@ unsigned long move_page_tables(struct vm_area_struct *vma, split_huge_pmd(vma, old_pmd, old_addr); if (pmd_trans_unstable(old_pmd)) continue; - } else if (extent == PMD_SIZE) { + } else if (!overlaps && extent == PMD_SIZE) { #ifdef CONFIG_HAVE_MOVE_PMD /* * If the extent is PMD-sized, try to speed the move by -- Kirill A. Shutemov