From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DE01C433E6 for ; Mon, 13 Jul 2020 17:22:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C5922207DD for ; Mon, 13 Jul 2020 17:22:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5922207DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B1478D0002; Mon, 13 Jul 2020 13:22:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53A288D0001; Mon, 13 Jul 2020 13:22:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4021F8D0002; Mon, 13 Jul 2020 13:22:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id 26E7A8D0001 for ; Mon, 13 Jul 2020 13:22:06 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B23EB181AEF07 for ; Mon, 13 Jul 2020 17:22:05 +0000 (UTC) X-FDA: 77033720610.15.drop11_1d082c926eea Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 815B71814B0C1 for ; Mon, 13 Jul 2020 17:22:05 +0000 (UTC) X-HE-Tag: drop11_1d082c926eea X-Filterd-Recvd-Size: 4197 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 17:22:05 +0000 (UTC) Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96F82206F5; Mon, 13 Jul 2020 17:22:01 +0000 (UTC) Date: Mon, 13 Jul 2020 18:21:59 +0100 From: Catalin Marinas To: Jon Hunter Cc: Zhenyu Ye , will@kernel.org, suzuki.poulose@arm.com, maz@kernel.org, steven.price@arm.com, guohanjun@huawei.com, olof@lixom.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arm@kernel.org, xiexiangyou@huawei.com, prime.zeng@hisilicon.com, zhangshaokun@hisilicon.com, kuhn.chenqun@huawei.com, linux-tegra Subject: Re: [PATCH v2 2/2] arm64: tlb: Use the TLBI RANGE feature in arm64 Message-ID: <20200713172158.GE15829@gaia> References: <20200710094420.517-1-yezhenyu2@huawei.com> <20200710094420.517-3-yezhenyu2@huawei.com> <4040f429-21c8-0825-2ad4-97786c3fe7c1@nvidia.com> <7237888d-2168-cd8b-c83d-c8e54871793d@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7237888d-2168-cd8b-c83d-c8e54871793d@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 815B71814B0C1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 13, 2020 at 03:44:16PM +0100, Jon Hunter wrote: > On 13/07/2020 15:39, Zhenyu Ye wrote: > > On 2020/7/13 22:27, Jon Hunter wrote: > >> After this change I am seeing the following build errors ... > >> > >> /tmp/cckzq3FT.s: Assembler messages: > >> /tmp/cckzq3FT.s:854: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:870: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:1095: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:1111: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:1964: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:1980: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:2286: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:2302: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x7' > >> /tmp/cckzq3FT.s:4833: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x6' > >> /tmp/cckzq3FT.s:4849: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x6' > >> /tmp/cckzq3FT.s:5090: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x6' > >> /tmp/cckzq3FT.s:5106: Error: unknown or missing operation name at operand 1 -- `tlbi rvae1is,x6' > >> /tmp/cckzq3FT.s:874: Error: attempt to move .org backwards > >> /tmp/cckzq3FT.s:1115: Error: attempt to move .org backwards > >> /tmp/cckzq3FT.s:1984: Error: attempt to move .org backwards > >> /tmp/cckzq3FT.s:2306: Error: attempt to move .org backwards > >> /tmp/cckzq3FT.s:4853: Error: attempt to move .org backwards > >> /tmp/cckzq3FT.s:5110: Error: attempt to move .org backwards > >> scripts/Makefile.build:280: recipe for target 'arch/arm64/mm/hugetlbpage.o' failed > >> make[3]: *** [arch/arm64/mm/hugetlbpage.o] Error 1 > >> scripts/Makefile.build:497: recipe for target 'arch/arm64/mm' failed > >> make[2]: *** [arch/arm64/mm] Error 2 > > > > The code must be built with binutils >= 2.30. > > Maybe I should add a check on whether binutils supports ARMv8.4-a instructions... > > Yes I believe so. The binutils guys in Arm confirmed that assembling "tlbi rvae1is" without -march=armv8.4-a is a bug. When it gets fixed, checking for the binutils version is not sufficient without passing -march. I think we are better off with a manual encoding of the instruction. -- Catalin