From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 280C0C433DF for ; Mon, 13 Jul 2020 16:45:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D8A71206F5 for ; Mon, 13 Jul 2020 16:45:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="YauW5eu+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8A71206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 87DE48D0008; Mon, 13 Jul 2020 12:45:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 806558D0001; Mon, 13 Jul 2020 12:45:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CF228D0008; Mon, 13 Jul 2020 12:45:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 564988D0001 for ; Mon, 13 Jul 2020 12:45:35 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C08D61DEB for ; Mon, 13 Jul 2020 16:45:34 +0000 (UTC) X-FDA: 77033628588.12.look12_2b03d9926ee9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 6BD821802504E for ; Mon, 13 Jul 2020 16:45:33 +0000 (UTC) X-HE-Tag: look12_2b03d9926ee9 X-Filterd-Recvd-Size: 3449 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 16:45:32 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id z17so14242679edr.9 for ; Mon, 13 Jul 2020 09:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YWJmchy5NBOUhyK5SwRwLbF2VzgzDqorZLs7Z4tlH84=; b=YauW5eu+U1WcnMWUhCH6USIo4RRa/4DjiT3BOcbbsGW0KeXV1YoHALoYmdaAuDYylQ xW3zY6dlDd+ktaWQENSLYYleqAJBN1mwxzFTHYSZhqqCbzDPkHsybQCD9Ue2e1XZtlDx VqnuSpVjTEL1T5Bs9LKIoi7gvVEmFp1gABikk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YWJmchy5NBOUhyK5SwRwLbF2VzgzDqorZLs7Z4tlH84=; b=YgjblomIJP/+lh2iDJVtiH5mpYd/wi3vdCD+hTYKGXswxQguMHxnaUUSr0WpAFQdKa EgD7UedLOegPzNdQVwuA25ghq+bU3/nzb2ROY6wKbvTTHieNcD6QvNN8YCZqmAScpRbx QlX3OBkxGxce6XThq3CSxSMYp9Zv3oWSyTQzdtjeSe5vfZI+NmwgYjbe+J1+Z4qe65TD 6VbFDTGgGflZSLGbcIMwLxYN+GBFjBNVGeViJmo00GB7q+KFK+fV8J6opovaxaTC8fPk 5hZcCIJnUPFcNbGfws6ju/qica70gWifI5rVT5wSlr2nRygX31hbn3OXyP5rNRYUljM1 j33Q== X-Gm-Message-State: AOAM530JdSdMFsAu2Tphz+wu6MPRbQx2mqdu/oEa+MLbHJRmUpNcOPw/ 5Skiph5zculnd1T+qnBVw1qMBg== X-Google-Smtp-Source: ABdhPJzcKhMEWkxja+nXz5D6veGVU3r4UEuSD2r7Zl/utZcyhS3svSDQ5ap7tYvz3qxodpWBKIGFLQ== X-Received: by 2002:a50:fd12:: with SMTP id i18mr256850eds.371.1594658731595; Mon, 13 Jul 2020 09:45:31 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:ef88]) by smtp.gmail.com with ESMTPSA id s7sm12186223edr.57.2020.07.13.09.45.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 09:45:31 -0700 (PDT) Date: Mon, 13 Jul 2020 17:45:30 +0100 From: Chris Down To: Matthew Wilcox Cc: Andrew Morton , Hugh Dickins , Al Viro , Amir Goldstein , Jeff Layton , Johannes Weiner , Tejun Heo , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v6 1/2] tmpfs: Per-superblock i_ino support Message-ID: <20200713164530.GB1065134@chrisdown.name> References: <2cddd4498ba1db1c7a3831d47b9db0d063746a3b.1594656618.git.chris@chrisdown.name> <20200713164145.GY12769@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200713164145.GY12769@casper.infradead.org> User-Agent: Mutt/1.14.5 (2020-06-23) X-Rspamd-Queue-Id: 6BD821802504E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox writes: >I don't think that works. I think you meant to write ~(SHMEM_INO_BATCH - 1). >Or just ino % SHMEM_INO_BATCH which works even for non-power-of-two. Er, right. I now wonder why I didn't just write `ino % SHMEM_INO_BATCH` :-) I'll send again with that fix.