From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E9FBC433E3 for ; Mon, 13 Jul 2020 16:41:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5F4E1206F5 for ; Mon, 13 Jul 2020 16:41:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RjTsw3Oe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F4E1206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CED328D0007; Mon, 13 Jul 2020 12:41:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9C3C8D0001; Mon, 13 Jul 2020 12:41:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD8F98D0007; Mon, 13 Jul 2020 12:41:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id A89EB8D0001 for ; Mon, 13 Jul 2020 12:41:56 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 377F7180AD802 for ; Mon, 13 Jul 2020 16:41:56 +0000 (UTC) X-FDA: 77033619432.17.nerve99_611624226ee9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 05882180D0185 for ; Mon, 13 Jul 2020 16:41:55 +0000 (UTC) X-HE-Tag: nerve99_611624226ee9 X-Filterd-Recvd-Size: 2260 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 16:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/smdC20zlWM8SPs5G47I6CVNiPuYGFy43OW503ZUCwE=; b=RjTsw3Oe8lcsM1sWH5Sqr3stoq X/cJMjzKyIgX7hDQQcrXyFtuuO7pPqUseEeeFQE2oayeIcIYgoo4kS31SAC7OZfGZesrACego17/e LDUu86YATcC2DfoVuNAenFSKu7Ep3J4Z/m6bCxVDf41IdQLXSBexhzwaPWxo9+8kAb6YMFCefz3Ut n4QOrPOEhurY59/py5smPdcslUdbxFMw6S7WKaKxfwzn7HtK+WAXJ64FJ9dyHxN0JLP4VbAWV+vfE 0Gqw6XJx3M7LbjGUn2RJJpQd8Lgw77p7S+Ll+QmQ5gri72zvnb3Hc+kP9vjJOc6gFex4FjmhYKjZx sY8sam+w==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv1WT-0003jZ-MK; Mon, 13 Jul 2020 16:41:45 +0000 Date: Mon, 13 Jul 2020 17:41:45 +0100 From: Matthew Wilcox To: Chris Down Cc: Andrew Morton , Hugh Dickins , Al Viro , Amir Goldstein , Jeff Layton , Johannes Weiner , Tejun Heo , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v6 1/2] tmpfs: Per-superblock i_ino support Message-ID: <20200713164145.GY12769@casper.infradead.org> References: <2cddd4498ba1db1c7a3831d47b9db0d063746a3b.1594656618.git.chris@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2cddd4498ba1db1c7a3831d47b9db0d063746a3b.1594656618.git.chris@chrisdown.name> X-Rspamd-Queue-Id: 05882180D0185 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 13, 2020 at 05:15:39PM +0100, Chris Down wrote: > +#define SHMEM_INO_BATCH 1024U ... > + if (unlikely((ino & ~SHMEM_INO_BATCH) == 0)) { I don't think that works. I think you meant to write ~(SHMEM_INO_BATCH - 1). Or just ino % SHMEM_INO_BATCH which works even for non-power-of-two.