From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E2CC433E2 for ; Mon, 13 Jul 2020 07:36:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9335E20849 for ; Mon, 13 Jul 2020 07:36:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9335E20849 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1F8778D0006; Mon, 13 Jul 2020 03:36:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A9C78D0002; Mon, 13 Jul 2020 03:36:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 098108D0006; Mon, 13 Jul 2020 03:36:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id E60998D0002 for ; Mon, 13 Jul 2020 03:36:41 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 92091180AD81A for ; Mon, 13 Jul 2020 07:36:41 +0000 (UTC) X-FDA: 77032245402.24.copy46_2b16a2e26ee6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 6AE3C1A4AA for ; Mon, 13 Jul 2020 07:36:41 +0000 (UTC) X-HE-Tag: copy46_2b16a2e26ee6 X-Filterd-Recvd-Size: 4215 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 07:36:40 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id z17so12123735edr.9 for ; Mon, 13 Jul 2020 00:36:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RNlyLtDhTs070oxTSGZLaWp85Uxt5nsU4hq+3vO7k6g=; b=Q0Z+5atd2nj8c07p5txoVeOJSpKhc3iaJvZNxetmbywCvfwMsEJrLPbht/AUOGNwJq UlCM26cBUAPS+dMCOt7DLAkT54Gb3TGwAMeeIpAcu2FDBClqHxBLupWLlWL7vlkoeR/F hvwLsIxAnMsTByPjhUEp3n18sOpVF8IfEUJqIzyURknJa7n3aX/Yy8R29tZVr23IoAuI PFcKNczEz6S9QQNA7YnPpcuzhIAdgNtIBQFwI7b0aNtW0WJGzDZrKTYCpxj+quAyvPhM qQFLdIYx1wcWtV3WfAH5dyzKSVQLcotvAFj2GvhfRhA1KBcSLZfNCfEGqr4rNbVTeX03 eK/w== X-Gm-Message-State: AOAM5312bEptnp2xywOXV7DQSfOWq/xcGcFx7rynf9NlXq4A83TWL81a Ah5ihmAyy3SGU7B4dZR71Rc= X-Google-Smtp-Source: ABdhPJwjAhFlCdCjn5HBG5LEiyBMZOyq0K+5Cn3M42gDs1iilObhr+c6UCzNEv2XsXdxpQAMc/ay+w== X-Received: by 2002:a05:6402:143c:: with SMTP id c28mr5630804edx.54.1594625799916; Mon, 13 Jul 2020 00:36:39 -0700 (PDT) Received: from localhost (ip-37-188-148-171.eurotel.cz. [37.188.148.171]) by smtp.gmail.com with ESMTPSA id rv16sm9263187ejb.60.2020.07.13.00.36.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 00:36:39 -0700 (PDT) Date: Mon, 13 Jul 2020 09:36:36 +0200 From: Michal Hocko To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Joonsoo Kim Subject: Re: [PATCH v5 4/9] mm/migrate: clear __GFP_RECLAIM to make the migration callback consistent with regular THP allocations Message-ID: <20200713073636.GC16783@dhcp22.suse.cz> References: <1594622517-20681-1-git-send-email-iamjoonsoo.kim@lge.com> <1594622517-20681-5-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594622517-20681-5-git-send-email-iamjoonsoo.kim@lge.com> X-Rspamd-Queue-Id: 6AE3C1A4AA X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 13-07-20 15:41:52, Joonsoo Kim wrote: > From: Joonsoo Kim > > new_page_nodemask is a migration callback and it tries to use a common > gfp flags for the target page allocation whether it is a base page or a > THP. The later only adds GFP_TRANSHUGE to the given mask. This results > in the allocation being slightly more aggressive than necessary because > the resulting gfp mask will contain also __GFP_RECLAIM_KSWAPD. THP > allocations usually exclude this flag to reduce over eager background > reclaim during a high THP allocation load which has been seen during > large mmaps initialization. There is no indication that this is a > problem for migration as well but theoretically the same might happen > when migrating large mappings to a different node. Make the migration > callback consistent with regular THP allocations. > > Signed-off-by: Joonsoo Kim Acked-by: Michal Hocko > --- > mm/migrate.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 3b3d918..1cfc965 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1547,6 +1547,11 @@ struct page *new_page_nodemask(struct page *page, > } > > if (PageTransHuge(page)) { > + /* > + * clear __GFP_RECALIM to make the migration callback > + * consistent with regular THP allocations. > + */ > + gfp_mask &= ~__GFP_RECLAIM; > gfp_mask |= GFP_TRANSHUGE; > order = HPAGE_PMD_ORDER; > } > -- > 2.7.4 > -- Michal Hocko SUSE Labs