From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD6ACC433E1 for ; Mon, 13 Jul 2020 06:21:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7DD9B20674 for ; Mon, 13 Jul 2020 06:21:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DD9B20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DFB768D0003; Mon, 13 Jul 2020 02:21:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAD478D0002; Mon, 13 Jul 2020 02:21:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC2AE8D0003; Mon, 13 Jul 2020 02:21:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0234.hostedemail.com [216.40.44.234]) by kanga.kvack.org (Postfix) with ESMTP id B67B08D0002 for ; Mon, 13 Jul 2020 02:21:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 35A4B21E4 for ; Mon, 13 Jul 2020 06:21:36 +0000 (UTC) X-FDA: 77032056192.04.money45_030605126ee6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 138908005906 for ; Mon, 13 Jul 2020 06:21:36 +0000 (UTC) X-HE-Tag: money45_030605126ee6 X-Filterd-Recvd-Size: 3712 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Jul 2020 06:21:35 +0000 (UTC) Received: by mail-ej1-f65.google.com with SMTP id y10so14879980eje.1 for ; Sun, 12 Jul 2020 23:21:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HiDmIjNlSH/9q4VN/ahAg5v0JqdukKXOYQ783T+y0DA=; b=l3xDdrgYu2V2k8fTpCFsVldMudg1Ow5LWLH/AW3tpxbJypDAbcVFNm/5IA/h5YYBWu Zg1I6hNceIKxAcpJR/QVdGA5tjGv5zaKpfYaWxpdvvTv2yofzCrjNIqXXrJ/53VMRIqe o5EOjOQKHR6rYROAVJUpYWakKbl+kiYey1kT0JVF9s0sEb5EsND0i4DTmE5GTQW5wqg+ e4z7GLa1pS5hetHRKTqjRqEOpAHltUToe2pasqT5fDD3qAT5dwfZRVVfU3oUToxUbOqU 4jBg9l/cW2ZERZ9gkQMsjoAGgYDB7yYEWJEplYvN+XqcYEFc7RhPe1j6X0KCuVyDaklJ GTLw== X-Gm-Message-State: AOAM532BGSPARrJEDeuLTjTN/AmRTj+N1kmlfseExNXiRKZhwM0vsiIR mVXmPB206e+0dAuQ7tbsG5Qpvp2J X-Google-Smtp-Source: ABdhPJx20f58geJUfZ9xooentmYN56U9WB8S52deMs5zT/pDMxSe5bkOurMsl9NknzvaB5eKJ4MrAQ== X-Received: by 2002:a17:906:194b:: with SMTP id b11mr66033795eje.28.1594621294770; Sun, 12 Jul 2020 23:21:34 -0700 (PDT) Received: from localhost (ip-37-188-148-171.eurotel.cz. [37.188.148.171]) by smtp.gmail.com with ESMTPSA id l6sm10455413edr.39.2020.07.12.23.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2020 23:21:34 -0700 (PDT) Date: Mon, 13 Jul 2020 08:21:32 +0200 From: Michal Hocko To: Yafang Shao Cc: rientjes@google.com, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm, oom: don't invoke oom killer if current has been reapered Message-ID: <20200713062132.GB16783@dhcp22.suse.cz> References: <1594437481-11144-1-git-send-email-laoar.shao@gmail.com> <20200713060154.GA16783@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200713060154.GA16783@dhcp22.suse.cz> X-Rspamd-Queue-Id: 138908005906 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 13-07-20 08:01:57, Michal Hocko wrote: > On Fri 10-07-20 23:18:01, Yafang Shao wrote: [...] > > There're many threads of a multi-threaded task parallel running in a > > container on many cpus. Then many threads triggered OOM at the same time, > > > > CPU-1 CPU-2 ... CPU-n > > thread-1 thread-2 ... thread-n > > > > wait oom_lock wait oom_lock ... hold oom_lock > > > > (sigkill received) > > > > select current as victim > > and wakeup oom reaper > > > > release oom_lock > > > > (MMF_OOM_SKIP set by oom reaper) > > > > (lots of pages are freed) > > hold oom_lock > > Could you be more specific please? The page allocator never waits for > the oom_lock and keeps retrying instead. Also __alloc_pages_may_oom > tries to allocate with the lock held. I suspect that you are looking at memcg oom killer. Because we do not do trylock there for some reason I do not immediatelly remember from top of my head. If this is really the case then I would recommend looking into how the page allocator implements this and follow the same pattern for memcg as well. -- Michal Hocko SUSE Labs