From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49B7AC433E0 for ; Sat, 11 Jul 2020 10:07:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D981920748 for ; Sat, 11 Jul 2020 10:07:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="PbiCT6rn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D981920748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3D39B6B0003; Sat, 11 Jul 2020 06:07:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35D546B0005; Sat, 11 Jul 2020 06:07:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 227346B0006; Sat, 11 Jul 2020 06:07:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id 0A31E6B0003 for ; Sat, 11 Jul 2020 06:07:50 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A3FC4180AD817 for ; Sat, 11 Jul 2020 10:07:49 +0000 (UTC) X-FDA: 77025368658.02.run63_550e4af26ed6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 7CD361000A970F63 for ; Sat, 11 Jul 2020 10:07:49 +0000 (UTC) X-HE-Tag: run63_550e4af26ed6 X-Filterd-Recvd-Size: 3558 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jul 2020 10:07:48 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id rk21so8677908ejb.2 for ; Sat, 11 Jul 2020 03:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VvgPMzxaIWY8gu27wsl9NLTmMwdfSRe2LBQ+aoof43M=; b=PbiCT6rnYpxjcdz78JSzc66U2jCPCKyCvdzn3eSBaprRlJVi0AoRb7r5GY28HdyQV8 0kzDCApIGdgRErMQYrTaNgOIeW7F+TnstVOfQnIBrJ74RW9Kp2lAyXtPSRwI3uYjnVdG RQVkMbMwPbpZHLiAwg8k5GsMrWWHsanOzaPZ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VvgPMzxaIWY8gu27wsl9NLTmMwdfSRe2LBQ+aoof43M=; b=nmgUvpvDrbg+A8rQSGi1kneB5OqnWq/YJQ5Rb5AdPZIwbqwad+hZLzT8/nZecr5p9K N8xYIcY4kh0XX35tN2KeT5MODYImdAI78V5d1b3KVVhnz+XoXRO4oIlyW96rPV41pbdr G7B+erj3yXWYMlvK88yBTJpq5mSOaCJPBqNUXtPjcrVn06PGzyAE2kTYGsqixHzVbUG+ jlHxF7KWDcOeHfUcvxuWHH90pgxLG5Zqo3VfnejjSQ82KNEMWtSeZOC3GFpd4BcyDF/o vw/a8fQzvpOHUDkQ0z1cTJ906zOHbECiqtXwojQODH96dfg9un+bTPCmYcqGH2y+fLWC AtTQ== X-Gm-Message-State: AOAM5331LPLPejAw06ODoh+ttFN+g8uGnesdiU9HX/f0QlDRcbVShUZj brPZWAiA+5WpFmsCaPPKWhQr9g== X-Google-Smtp-Source: ABdhPJwDfkL/WJa2Dbdi6wpQKziY+VZNw5BInEihKFhEvNyxeYNGxcpd3iw/1vjMlfuO1RYGaRPc9g== X-Received: by 2002:a17:906:ca56:: with SMTP id jx22mr64001808ejb.494.1594462067714; Sat, 11 Jul 2020 03:07:47 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:8860]) by smtp.gmail.com with ESMTPSA id y11sm5150377ejw.63.2020.07.11.03.07.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jul 2020 03:07:47 -0700 (PDT) Date: Sat, 11 Jul 2020 11:07:46 +0100 From: Chris Down To: Shakeel Butt Cc: Johannes Weiner , Roman Gushchin , Michal Hocko , Yafang Shao , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmscan: consistent update to pgrefill Message-ID: <20200711100746.GA814207@chrisdown.name> References: <20200711011459.1159929-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200711011459.1159929-1-shakeelb@google.com> User-Agent: Mutt/1.14.5 (2020-06-23) X-Rspamd-Queue-Id: 7CD361000A970F63 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.009296, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Shakeel Butt writes: >The vmstat pgrefill is useful together with pgscan and pgsteal stats to >measure the reclaim efficiency. However vmstat's pgrefill is not updated >consistently at system level. It gets updated for both global and memcg >reclaim however pgscan and pgsteal are updated for only global reclaim. >So, update pgrefill only for global reclaim. If someone is interested in >the stats representing both system level as well as memcg level reclaim, >then consult the root memcg's memory.stat instead of /proc/vmstat. > >Signed-off-by: Shakeel Butt Acked-by: Chris Down