From: Chris Down <chris@chrisdown.name>
To: Shakeel Butt <shakeelb@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Roman Gushchin <guro@fb.com>, Michal Hocko <mhocko@kernel.org>,
Yafang Shao <laoar.shao@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: vmscan: consistent update to pgrefill
Date: Sat, 11 Jul 2020 11:07:46 +0100 [thread overview]
Message-ID: <20200711100746.GA814207@chrisdown.name> (raw)
In-Reply-To: <20200711011459.1159929-1-shakeelb@google.com>
Shakeel Butt writes:
>The vmstat pgrefill is useful together with pgscan and pgsteal stats to
>measure the reclaim efficiency. However vmstat's pgrefill is not updated
>consistently at system level. It gets updated for both global and memcg
>reclaim however pgscan and pgsteal are updated for only global reclaim.
>So, update pgrefill only for global reclaim. If someone is interested in
>the stats representing both system level as well as memcg level reclaim,
>then consult the root memcg's memory.stat instead of /proc/vmstat.
>
>Signed-off-by: Shakeel Butt <shakeelb@google.com>
Acked-by: Chris Down <chris@chrisdown.name>
prev parent reply other threads:[~2020-07-11 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 1:14 Shakeel Butt
2020-07-11 1:54 ` Yafang Shao
2020-07-11 2:31 ` Roman Gushchin
2020-07-11 3:24 ` Shakeel Butt
2020-07-11 10:07 ` Chris Down [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711100746.GA814207@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox