From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC155C433E4 for ; Fri, 10 Jul 2020 20:26:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8BBDB20748 for ; Fri, 10 Jul 2020 20:26:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="gA9SGosl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BBDB20748 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7CA826B0006; Fri, 10 Jul 2020 16:26:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72CB36B0007; Fri, 10 Jul 2020 16:26:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 66A436B0008; Fri, 10 Jul 2020 16:26:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 4C6B86B0006 for ; Fri, 10 Jul 2020 16:26:52 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 13F9E2C32 for ; Fri, 10 Jul 2020 20:26:52 +0000 (UTC) X-FDA: 77023299864.07.wash12_0603d2b26ed1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 7088A1803F901 for ; Fri, 10 Jul 2020 20:26:48 +0000 (UTC) X-HE-Tag: wash12_0603d2b26ed1 X-Filterd-Recvd-Size: 2435 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 20:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=4QXJNNjEsP4Gd/OfGl1zV8Q0J89UWaySKggHFZHPz60=; b=gA9SGoslIQ2t6c1aa3YYTW5QwA gc+N0+7JwP6ojWzqlLqwEJi4jzxxlUfemdryegjFA9j0uTJy/G5cUop/fJJoTgSLSMAokkiZmlAH/ aboJbskJltd+n1m03EOLN19GfH8DU9nlkvRArahd5g/+B2XSNhiBw2u1MxoD3qhs8vhddDFxvAPnG 0TeBDYpHd7DfQbDoXD9ecERONw5ZIGs/+uI9b1BD1G/m10fzT6fr/zbIQBL0tidYjRa5ylc7jQnbW wAGzCjP85xlOj3vUlKP1ll8RcLE7MFKp5o9uXvzHxXxIuWPeV93P63qK9QWqiKmnrMlGJ45sEtDel X0prmReQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtzba-0005gn-8d; Fri, 10 Jul 2020 20:26:46 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" Subject: [PATCH 4/4] proc: Optimise smaps for shmem entries Date: Fri, 10 Jul 2020 21:26:42 +0100 Message-Id: <20200710202642.21794-5-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200710202642.21794-1-willy@infradead.org> References: <20200710202642.21794-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 7088A1803F901 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Avoid bumping the refcount on pages when we're only interested in the swap entries. Signed-off-by: Matthew Wilcox (Oracle) --- fs/proc/task_mmu.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index dbda4499a859..7346f7cbbcc1 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -520,16 +520,10 @@ static void smaps_pte_entry(pte_t *pte, unsigned lo= ng addr, page =3D device_private_entry_to_page(swpent); } else if (unlikely(IS_ENABLED(CONFIG_SHMEM) && mss->check_shmem_swap && pte_none(*pte))) { - page =3D find_get_entry(vma->vm_file->f_mapping, + page =3D xa_load(&vma->vm_file->f_mapping->i_pages, linear_page_index(vma, addr)); - if (!page) - return; - if (xa_is_value(page)) mss->swap +=3D PAGE_SIZE; - else - put_page(page); - return; } =20 --=20 2.27.0