From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C8A5C433E6 for ; Fri, 10 Jul 2020 19:45:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D9D420748 for ; Fri, 10 Jul 2020 19:45:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YMb7iDYi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D9D420748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DCA8D6B0006; Fri, 10 Jul 2020 15:44:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D79A66B0007; Fri, 10 Jul 2020 15:44:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C69A88D0001; Fri, 10 Jul 2020 15:44:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id ADC0A6B0006 for ; Fri, 10 Jul 2020 15:44:59 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 759481DE5 for ; Fri, 10 Jul 2020 19:44:59 +0000 (UTC) X-FDA: 77023194318.20.curve70_5e1827826ed1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 4DBD7180C07AF for ; Fri, 10 Jul 2020 19:44:52 +0000 (UTC) X-HE-Tag: curve70_5e1827826ed1 X-Filterd-Recvd-Size: 3956 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 19:44:51 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id h19so7707010ljg.13 for ; Fri, 10 Jul 2020 12:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5Jefdz/yaOaAhqlfQ2b25fK1L/1k8801ZS9K7lHkt5E=; b=YMb7iDYiLk8dHq9kJdyGEpQnaZFcjmM/MmodM9yoolYsNlxXTwnkYl87mocs3EQUW3 9u3X4fd+qN8Ynkm4ByDjD14ROLyN2oWUBycHHAlHl6a1qnykSgR1FTkMgXrs1kGZBxvt k4WaQ6+keuez4pbRr62eRCOz+DWK0l1Tfy05mrGgPtJuR+zgfBdvjuyk/GXBsy9FyB4x yCk4fW2PLTj2XDuHb+rQQgJoi+t3lsiBVVshUvX/y9NofoFAgQMTXueDh+zjQah4Jzyl HXA2u1XKFKruO7D6y2YzzSAbdwO2uWp111oplH0XrbVpbxiiMmHoElZkRecMxsx3uYOB zm9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5Jefdz/yaOaAhqlfQ2b25fK1L/1k8801ZS9K7lHkt5E=; b=FPTidf/Pm20/Y0UaoalQwfsBSYllF8WkMiQwKVNtjg4L1dMj3CJ7NXfXinXGp8G2tr fLmTniNcQKuok0+zVwgytWUxiNXWUYD+iN8mYJ0zupRuH0laTW2sO45WWGndK/xKeyBY ABIajD0ss/yuaoyagrtywgyJ39mcIiF3kImIpjtxzWDbtL+JnkSLligX44FHHE0AKIIx Iyv5WTT9iCyYV5edlxNVBOJ/SN6v83GN2GGBV09zPZmiioEx+gQs5R1E8k/Y4UViTuWg u/fLJvXBUCgDznZYXoyAafhu9pVne8k9j+XL75bp/O19PIRBrglMOHA3XAsXbtPdv6Ua xieQ== X-Gm-Message-State: AOAM532rUfkizLYimbzmAiHVOumwBBji5Bm06xy8E71LKiTpLbVFUpcB vCLvs3RGuvHXDCHriWDJwVY= X-Google-Smtp-Source: ABdhPJza4yxsAwxkWbnE2BL6yZTMcJPZFM0gSKEtlVvUUSDmiI9YEYoUJi1agaHDdYHLOhN4fw7KOA== X-Received: by 2002:a2e:971a:: with SMTP id r26mr44521211lji.464.1594410290537; Fri, 10 Jul 2020 12:44:50 -0700 (PDT) Received: from pc638.lan (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id n4sm2493161lfl.40.2020.07.10.12.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 12:44:50 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Uladzislau Rezki , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: [PATCH v2 1/1] mm/vmalloc.c: Add an error message if two areas overlap Date: Fri, 10 Jul 2020 21:44:43 +0200 Message-Id: <20200710194443.2984-1-urezki@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 4DBD7180C07AF X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000121, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Before triggering a BUG() it would be useful to understand how two areas overlap between each other. Print information about start/end addresses of both VAs and their addresses. For example if both are identical it could mean double free. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 5a2b55c8dd9a..db2e1020dc51 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -549,8 +549,13 @@ find_va_links(struct vmap_area *va, else if (va->va_end > tmp_va->va_start && va->va_start >=3D tmp_va->va_end) link =3D &(*link)->rb_right; - else + else { + pr_err("Overlaps: 0x%px(0x%lx-0x%lx), 0x%px(0x%lx-0x%lx)\n", + va, va->va_start, va->va_end, tmp_va, + tmp_va->va_start, tmp_va->va_end); + BUG(); + } } while (*link); =20 *parent =3D &tmp_va->rb_node; --=20 2.20.1