From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 784D6C433E0 for ; Fri, 10 Jul 2020 19:44:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3499720748 for ; Fri, 10 Jul 2020 19:44:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hG7WGrtS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3499720748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D7CAA6B0005; Fri, 10 Jul 2020 15:44:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D53316B0006; Fri, 10 Jul 2020 15:44:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C45998D0001; Fri, 10 Jul 2020 15:44:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id B020B6B0005 for ; Fri, 10 Jul 2020 15:44:36 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 731EB18013677 for ; Fri, 10 Jul 2020 19:44:36 +0000 (UTC) X-FDA: 77023193352.19.yard85_0a1868526ed1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id D69E31AE911 for ; Fri, 10 Jul 2020 19:44:07 +0000 (UTC) X-HE-Tag: yard85_0a1868526ed1 X-Filterd-Recvd-Size: 4656 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 19:44:07 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id z24so7729913ljn.8 for ; Fri, 10 Jul 2020 12:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Vysk606sA8Of187qvDUDNcu+jxfwy3DGDePacF31O0s=; b=hG7WGrtSDxdwGVkQjtZ+Y0iAl4ZZqcd3EQ8sd8z6by6q5DAINsG5VezAUyhGVnIW1M ab7K3ppN6SalgSu0tnFSzp7FZSERs9Zg84KqXPEl5RpHUmV1g4D3XvAho0vxhuG0uk/o A6Cm+x4GRLR9hovvB6CIUJnUiV9zXG7bsbBROrMZvNa+XaSVshWMh40w+QBzmBWT7hpC /wq4NEY5awSO1vegII9l9SX/soRTyUltBVR9tzsnqzKAz1AIIx3YdnrxDQd+XIpSsT0h tJo/pCJmtre+eI/Bc7TGY70cI9znBEtCii8C3cfCYsZz653i8B0ewKfEtWlF2PouQMKA bhoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Vysk606sA8Of187qvDUDNcu+jxfwy3DGDePacF31O0s=; b=VFyQ6NAvXysjdm8/4BeMtJXcTPTapQ//jgEHNtc63+YpKZtJQNFzNpcqH+iKxp9bCn ct1Yw9oVlz4pTRalnle9fFfLDBkPLDvWvMBNLLmk2pOLa7F7IllKYkJl6C7ZlKv6KWuC Ax9JWhn1BvVNH5XJf+8HxS7iI/Ar3V9tdAPlFtksjEn7//WUV0xmH3z/Zf8VqFa+USnJ KzgoXUiexSoFgVYozKYTgwl14g1Sihl4oMFl2z/OolIWifS1N8psMnhFFu09OnBc5dLN iqx7445etk4skGG0VXtIfGZjWs66FnfQeXmxrECgmynDbSiF4magQuQqcrWKwj7NKcOC e/EQ== X-Gm-Message-State: AOAM5313BFlk1c9Vz8834pmWlJFUwH94xF+iFUFphnoyCiX5+UZJlJPZ YYV/sp+CYHkYGOqpllG+lrmlX55defLXDg== X-Google-Smtp-Source: ABdhPJwz3TpyJMmekzxnbo03lbvdeO6i0Wor3mW4aXErkdi+M0+pbDMj2RTXVokJ+ciJGa2xfMhM+g== X-Received: by 2002:a2e:b5c8:: with SMTP id g8mr25458864ljn.38.1594410246213; Fri, 10 Jul 2020 12:44:06 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id 16sm2181362ljw.127.2020.07.10.12.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 12:44:05 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 10 Jul 2020 21:44:03 +0200 To: Andrew Morton Cc: Andrew Morton , linux-mm@kvack.org, LKML , Hillf Danton , Michal Hocko , Matthew Wilcox , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH 1/1] mm/vmalloc.c: Add an error message if two areas overlap Message-ID: <20200710194403.GA19388@pc636> References: <20200710194042.2510-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710194042.2510-1-urezki@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: D69E31AE911 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Before triggering a BUG() it would be useful to understand > how two areas overlap between each other. Print information > about start/end addresses of both VAs and their addresses. > > For example if both are identical it could mean double free. > > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 5a2b55c8dd9a..1679b01febcd 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -549,8 +549,13 @@ find_va_links(struct vmap_area *va, > else if (va->va_end > tmp_va->va_start && > va->va_start >= tmp_va->va_end) > link = &(*link)->rb_right; > - else > + else { > + pr_err("Overlaps: 0x%px(0x%lx-0x%lx), 0x%px(0x%lx-0x%lx)\n", > + va, va->va_start, va->va_end, tmp_va, > + tmp_va->va_start, tmp_va->va_end); > + > BUG(); > + } > } while (*link); > > *parent = &tmp_va->rb_node; > @@ -1993,6 +1998,9 @@ static void vmap_init_free_space(void) > insert_vmap_area_augment(free, NULL, > &free_vmap_area_root, > &free_vmap_area_list); > + insert_vmap_area_augment(free, NULL, > + &free_vmap_area_root, > + &free_vmap_area_list); > } > } > } > Please ignore this patch, i will upload v2. Sorry for inconvenience. -- Vlad Rezki