From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67141C433E8 for ; Fri, 10 Jul 2020 13:07:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E7B1207BB for ; Fri, 10 Jul 2020 13:07:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E7B1207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 90A3D8D0002; Fri, 10 Jul 2020 09:07:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BA108D0001; Fri, 10 Jul 2020 09:07:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8034B8D0002; Fri, 10 Jul 2020 09:07:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id 681818D0001 for ; Fri, 10 Jul 2020 09:07:30 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EFFCD18034A74 for ; Fri, 10 Jul 2020 13:07:29 +0000 (UTC) X-FDA: 77022192618.12.size74_6117ecc26ece Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id C47C4180559F1 for ; Fri, 10 Jul 2020 13:07:27 +0000 (UTC) X-HE-Tag: size74_6117ecc26ece X-Filterd-Recvd-Size: 3026 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 13:07:27 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id w16so5963637ejj.5 for ; Fri, 10 Jul 2020 06:07:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pfcMmD264TAA0dG7QgEoTJZr3IrsKKESoJiHSw+ewYE=; b=r08nqC+uF69sAgN+UnapGgqQVWAnpPhy8P7fvPWBAopLmQiVH/h2YAjx/Aw3taV/TY sNr23C9JBBChu7OI0Ik3P2tWVnFNnOZefgwkGW7/aTUwtA0Hy2G8R9DRQyyOMMmzdHh+ j1efiVSvYl8JHOzZFGZ7L5ZS9cvKR4xbIdLAZvti/3bUj2x6nmkHn9a4CTLF5ITFBbmt QtXKn8XcHte7BjP8hVtDkab2QkQadCEzX55dgh7sDy8qI5AMswTInwHO97DLVV+i7Ujc kYYMpZI4pC7Up3FMpGRCrEhofWkWi4w4z3Ci91cATkCeT1GDlTEIAygwKZ5vq/hkawrg rHCw== X-Gm-Message-State: AOAM532J4lbizoVfXslnIihr1bFF+5LKax01vLXPTkwNmnPNT+gcDz88 fGdTVHDJoKExTMMYlq6jaTY= X-Google-Smtp-Source: ABdhPJzcCCNv0glzJfkwqkDnWUvTMpd4BkwXYu6/DqoyRKcGl+Nm4u0bPblVcZU65jx0Zx/rJB1N8A== X-Received: by 2002:a17:906:e089:: with SMTP id gh9mr36717032ejb.482.1594386446427; Fri, 10 Jul 2020 06:07:26 -0700 (PDT) Received: from localhost (ip-37-188-148-171.eurotel.cz. [37.188.148.171]) by smtp.gmail.com with ESMTPSA id u13sm4330481eds.10.2020.07.10.06.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 06:07:25 -0700 (PDT) Date: Fri, 10 Jul 2020 15:07:24 +0200 From: Michal Hocko To: Qian Cai Cc: Yafang Shao , rientjes@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm, oom: make the calculation of oom badness more accurate Message-ID: <20200710130724.GD3022@dhcp22.suse.cz> References: <1594309987-9919-1-git-send-email-laoar.shao@gmail.com> <20200710124253.GA1125@lca.pw> <20200710125852.GC3022@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200710125852.GC3022@dhcp22.suse.cz> X-Rspamd-Queue-Id: C47C4180559F1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 10-07-20 14:58:54, Michal Hocko wrote: [...] > I will have a closer look. Is the full dmesg available somewhere? Ups, I have missed this: diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 2dd5a90f2f81..7f01835862f4 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -306,7 +306,7 @@ static enum oom_constraint constrained_alloc(struct oom_control *oc) static int oom_evaluate_task(struct task_struct *task, void *arg) { struct oom_control *oc = arg; - unsigned long points; + long points; if (oom_unkillable_task(task)) goto next; Does it help? -- Michal Hocko SUSE Labs