From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29AF2C433E0 for ; Thu, 9 Jul 2020 16:48:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E19D2207DD for ; Thu, 9 Jul 2020 16:48:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E19D2207DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6B3066B0005; Thu, 9 Jul 2020 12:48:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6624D6B0006; Thu, 9 Jul 2020 12:48:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57A416B0007; Thu, 9 Jul 2020 12:48:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 430D06B0005 for ; Thu, 9 Jul 2020 12:48:54 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 095A7181AEF00 for ; Thu, 9 Jul 2020 16:48:54 +0000 (UTC) X-FDA: 77019121788.18.skate10_4913fb126ec7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id CACD4100ED3C3 for ; Thu, 9 Jul 2020 16:48:53 +0000 (UTC) X-HE-Tag: skate10_4913fb126ec7 X-Filterd-Recvd-Size: 2344 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 16:48:53 +0000 (UTC) Received: from gaia (unknown [95.146.230.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 90EDC20720; Thu, 9 Jul 2020 16:48:48 +0000 (UTC) Date: Thu, 9 Jul 2020 17:48:46 +0100 From: Catalin Marinas To: Zhenyu Ye Cc: peterz@infradead.org, mark.rutland@arm.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, npiggin@gmail.com, arnd@arndb.de, rostedt@goodmis.org, maz@kernel.org, suzuki.poulose@arm.com, tglx@linutronix.de, yuzhao@google.com, Dave.Martin@arm.com, steven.price@arm.com, broonie@kernel.org, guohanjun@huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arm@kernel.org, xiexiangyou@huawei.com, prime.zeng@hisilicon.com, zhangshaokun@hisilicon.com, kuhn.chenqun@huawei.com Subject: Re: [RESEND PATCH v5 3/6] arm64: Add tlbi_user_level TLB invalidation helper Message-ID: <20200709164845.GB6579@gaia> References: <20200625080314.230-1-yezhenyu2@huawei.com> <20200625080314.230-4-yezhenyu2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625080314.230-4-yezhenyu2@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: CACD4100ED3C3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 25, 2020 at 04:03:11PM +0800, Zhenyu Ye wrote: > @@ -189,8 +195,9 @@ static inline void flush_tlb_page_nosync(struct vm_area_struct *vma, > unsigned long addr = __TLBI_VADDR(uaddr, ASID(vma->vm_mm)); > > dsb(ishst); > - __tlbi(vale1is, addr); > - __tlbi_user(vale1is, addr); > + /* This function is only called on a small page */ > + __tlbi_level(vale1is, addr, 3); > + __tlbi_user_level(vale1is, addr, 3); > } Actually, that's incorrect. It was ok in v2 of your patches when I suggested to drop level 0, just leave the function unchanged but I missed that you updated it to pass level 3. pmdp_set_access_flags -> ptep_set_access_flags -> flush_tlb_fix_spurious_fault -> flush_tlb_page -> flush_tlb_page_nosync. -- Catalin