From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D7EBC433E0 for ; Thu, 9 Jul 2020 14:00:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DF00520708 for ; Thu, 9 Jul 2020 14:00:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF00520708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8A1836B0006; Thu, 9 Jul 2020 10:00:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82AD36B0007; Thu, 9 Jul 2020 10:00:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71A4D6B0008; Thu, 9 Jul 2020 10:00:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 56F5D6B0006 for ; Thu, 9 Jul 2020 10:00:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EC64B2C7C for ; Thu, 9 Jul 2020 14:00:19 +0000 (UTC) X-FDA: 77018696958.01.maid59_0615d8326ec6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id A461060001B37999 for ; Thu, 9 Jul 2020 13:59:23 +0000 (UTC) X-HE-Tag: maid59_0615d8326ec6 X-Filterd-Recvd-Size: 3045 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 13:59:22 +0000 (UTC) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jtW5g-0003zp-Am; Thu, 09 Jul 2020 22:55:53 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 09 Jul 2020 22:55:52 +1000 Date: Thu, 9 Jul 2020 22:55:52 +1000 From: Herbert Xu To: Barry Song Cc: davem@davemloft.net, wangzhou1@hisilicon.com, jonathan.cameron@huawei.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH v3 0/3] crypto: allow users to specify acomp hardware from a desired NUMA node Message-ID: <20200709125552.GG31057@gondor.apana.org.au> References: <20200705091900.29232-1-song.bao.hua@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200705091900.29232-1-song.bao.hua@hisilicon.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: A461060001B37999 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 05, 2020 at 09:18:57PM +1200, Barry Song wrote: > For a typical Linux server, probably there are multiple ZIP modules. > For example, numa node0 has a compressor, numa node2 has a same module. > Some drivers are automatically using the module near the CPU calling > acomp_alloc. > But it isn't necessarily correct. Just like memory allocation API like > kmalloc and kmalloc_node. Similar optimization may be done for crypto. > > -v3: > move to use kzalloc_node according to Herbert's comment > -v2: > cleanup according to Jonathan Cameron's comment > > Barry Song (3): > crypto: permit users to specify numa node of acomp hardware > crypto: hisilicon/zip - permit users to specify NUMA node > mm/zswap: allocate acomp on the numa node committing acomp_req[1] > > [1] This patch is againest a zswap patch which has not been merged yet: > "[PATCH v3] mm/zswap: move to use crypto_acomp API for hardware > acceleration" > https://lkml.org/lkml/2020/6/26/95 > > crypto/acompress.c | 8 ++++++++ > crypto/api.c | 24 ++++++++++++++--------- > crypto/internal.h | 23 ++++++++++++++++++---- > drivers/crypto/hisilicon/zip/zip.h | 2 +- > drivers/crypto/hisilicon/zip/zip_crypto.c | 6 +++--- > drivers/crypto/hisilicon/zip/zip_main.c | 5 +++-- > include/crypto/acompress.h | 18 +++++++++++++++++ > include/linux/crypto.h | 2 ++ > mm/zswap.c | 2 +- > 9 files changed, 70 insertions(+), 20 deletions(-) Patches 1-2 applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt