From: Herbert Xu <herbert@gondor.apana.org.au>
To: Barry Song <song.bao.hua@hisilicon.com>
Cc: davem@davemloft.net, wangzhou1@hisilicon.com,
jonathan.cameron@huawei.com, akpm@linux-foundation.org,
linux-crypto@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH v3 0/3] crypto: allow users to specify acomp hardware from a desired NUMA node
Date: Thu, 9 Jul 2020 22:55:52 +1000 [thread overview]
Message-ID: <20200709125552.GG31057@gondor.apana.org.au> (raw)
In-Reply-To: <20200705091900.29232-1-song.bao.hua@hisilicon.com>
On Sun, Jul 05, 2020 at 09:18:57PM +1200, Barry Song wrote:
> For a typical Linux server, probably there are multiple ZIP modules.
> For example, numa node0 has a compressor, numa node2 has a same module.
> Some drivers are automatically using the module near the CPU calling
> acomp_alloc.
> But it isn't necessarily correct. Just like memory allocation API like
> kmalloc and kmalloc_node. Similar optimization may be done for crypto.
>
> -v3:
> move to use kzalloc_node according to Herbert's comment
> -v2:
> cleanup according to Jonathan Cameron's comment
>
> Barry Song (3):
> crypto: permit users to specify numa node of acomp hardware
> crypto: hisilicon/zip - permit users to specify NUMA node
> mm/zswap: allocate acomp on the numa node committing acomp_req[1]
>
> [1] This patch is againest a zswap patch which has not been merged yet:
> "[PATCH v3] mm/zswap: move to use crypto_acomp API for hardware
> acceleration"
> https://lkml.org/lkml/2020/6/26/95
>
> crypto/acompress.c | 8 ++++++++
> crypto/api.c | 24 ++++++++++++++---------
> crypto/internal.h | 23 ++++++++++++++++++----
> drivers/crypto/hisilicon/zip/zip.h | 2 +-
> drivers/crypto/hisilicon/zip/zip_crypto.c | 6 +++---
> drivers/crypto/hisilicon/zip/zip_main.c | 5 +++--
> include/crypto/acompress.h | 18 +++++++++++++++++
> include/linux/crypto.h | 2 ++
> mm/zswap.c | 2 +-
> 9 files changed, 70 insertions(+), 20 deletions(-)
Patches 1-2 applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2020-07-09 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 9:18 Barry Song
2020-07-05 9:18 ` [PATCH v3 1/3] crypto: permit users to specify numa node of acomp hardware Barry Song
2020-07-05 9:18 ` [PATCH v3 2/3] crypto: hisilicon/zip - permit users to specify NUMA node Barry Song
2020-07-05 9:19 ` [PATCH v3 3/3] mm/zswap: allocate acomp on the numa node committing acomp_req Barry Song
2020-07-09 12:55 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709125552.GG31057@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jonathan.cameron@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=song.bao.hua@hisilicon.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox