From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A528C433DF for ; Thu, 9 Jul 2020 09:40:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E4015206C3 for ; Thu, 9 Jul 2020 09:40:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FavBHG8I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4015206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 817C46B0006; Thu, 9 Jul 2020 05:40:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C95B6B0007; Thu, 9 Jul 2020 05:40:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 640D76B0008; Thu, 9 Jul 2020 05:40:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id 4D5656B0006 for ; Thu, 9 Jul 2020 05:40:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id ED1668248D7C for ; Thu, 9 Jul 2020 09:40:00 +0000 (UTC) X-FDA: 77018040960.23.meat26_5c11bd426ec4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id BE5B437606 for ; Thu, 9 Jul 2020 09:40:00 +0000 (UTC) X-HE-Tag: meat26_5c11bd426ec4 X-Filterd-Recvd-Size: 6233 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 09:40:00 +0000 (UTC) Received: by mail-ej1-f66.google.com with SMTP id w6so1582242ejq.6 for ; Thu, 09 Jul 2020 02:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2THE/Ch7o0atdMFuV+uYcIIPapd2rod4QXyGDJ/dFko=; b=FavBHG8IG2M/1g82xJw00majkxmSP5shEMXvMHDHe7094E4Hs00vjp8TSSeR812KOm uC7FGqeoRqCDwBgdgygc/j1M0Msyq/Ih3poWhDEiWpFtl68h4WZWGazIM4Nb76BfjWKN tzXZHrubqlL/oEkduaS00KzNt4j/7hWc+bBdZBkZ0sR4ZauY5UmPmwJGHDi20CGqw+S9 A/ofjh4eAf0kBuaLw/NQbbbbm4RNOztwCCAt6vX3Jlo1wlr4gj/NKXc0I47EcR5lzOF/ UCTt8pKDGUbPmgFRlhMpkF+INN5Ld1zjZLpvr12d6Fca3LQNgtvD2qy/WRGnQGNt84y8 UdAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2THE/Ch7o0atdMFuV+uYcIIPapd2rod4QXyGDJ/dFko=; b=fdqaqa0p3UCXRL6ghM6akR0MKlpT/hGd4qc1h3inJFfNsEzfJjPUCcFhCWvvcuSxXV Gzkvoyxs8QqbBEPRRgOabySu0qjgWjmwGKMt4YNIRo1vgEpUl9sYExTEvzg+9rhSsp1s qpQou7RTGfnQ0l3B2tE+Zm5P/ywtRkGjFw2Bv/5S/fXp8Rdp9QvliQXq9lbH6kQMMeit cAw5ptJUv9uYpvphKw0+YQnnMg4Ux0pSTjOe0lMqwFP/vls15dIVJUg2QWzpaZRdTwdp Sx9QszxbOlC9YfaWueGMnPV5nJrvGLIYEqSisal5CmTer25J2YT7+xD/VUubp3VgA9PT Hxlw== X-Gm-Message-State: AOAM53060U+8mdPOrXOE1ru2fqtgMJmufKycBxFrQmJ+Az+C7lauLV3I lqi1gA7c/jkj9XUxr3OGAfuu2A== X-Google-Smtp-Source: ABdhPJwRIJMZIpLlplX9lPskZd1R8tF64miPnKHMtY82fk3Knb0HoMgI+IgSJLyxwoNHoioyY3/W0A== X-Received: by 2002:a17:906:945:: with SMTP id j5mr56100930ejd.52.1594287599016; Thu, 09 Jul 2020 02:39:59 -0700 (PDT) Received: from myrica ([2001:1715:4e26:a7e0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id q21sm1428288ejr.75.2020.07.09.02.39.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 02:39:58 -0700 (PDT) Date: Thu, 9 Jul 2020 11:39:46 +0200 From: Jean-Philippe Brucker To: iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Cc: joro@8bytes.org, catalin.marinas@arm.com, will@kernel.org, robin.murphy@arm.com, baolu.lu@linux.intel.com, Jonathan.Cameron@huawei.com, jacob.jun.pan@linux.intel.com, zhangfei.gao@linaro.org, xuzaibo@huawei.com, zhengxiang9@huawei.com, fenghua.yu@intel.com, hch@infradead.org Subject: Re: [PATCH v8 00/12] iommu: Shared Virtual Addressing for SMMUv3 (PT sharing part) Message-ID: <20200709093946.GC4477@myrica> References: <20200618155125.1548969-1-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618155125.1548969-1-jean-philippe@linaro.org> X-Rspamd-Queue-Id: BE5B437606 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Will, On Thu, Jun 18, 2020 at 05:51:13PM +0200, Jean-Philippe Brucker wrote: > Since v7 [1], I split the series into three parts to ease review. This > first one adds page table sharing to the SMMUv3 driver. The second one > adds support for I/O page faults through PRI and Stall, and the last one > adds additional and optional features (DVM, VHE and HTTU). SVA needs the > three parts to work. No significant change apart from that, I just > addressed the previous comments. > > I'd rather everything went through the IOMMU tree but I'm assuming patch > 1 will also go through the x86 tree as part of [2]. It is definitely > required by patch 3 which is required by patch 11. I don't know how this > kind of conflict is usually resolved, but if it's a problem I could > further shrink the series to only patches 4-10 this cycle. I have one bugfix for this series but am planning to hold off resending until you've found time to have a look. I can also reduce it to 7 patches for v4.9, please let me know what you prefer. Thanks, Jean > > [1] https://lore.kernel.org/linux-iommu/20200519175502.2504091-1-jean-philippe@linaro.org/ > [2] https://lore.kernel.org/linux-iommu/1592418233-17762-1-git-send-email-fenghua.yu@intel.com/ > > Fenghua Yu (1): > mm: Define pasid in mm > > Jean-Philippe Brucker (11): > iommu/ioasid: Add ioasid references > iommu/sva: Add PASID helpers > arm64: mm: Pin down ASIDs for sharing mm with devices > iommu/io-pgtable-arm: Move some definitions to a header > arm64: cpufeature: Export symbol read_sanitised_ftr_reg() > iommu/arm-smmu-v3: Share process page tables > iommu/arm-smmu-v3: Seize private ASID > iommu/arm-smmu-v3: Check for SVA features > iommu/arm-smmu-v3: Add SVA device feature > iommu/arm-smmu-v3: Implement iommu_sva_bind/unbind() > iommu/arm-smmu-v3: Hook up ATC invalidation to mm ops > > drivers/iommu/Kconfig | 7 + > drivers/iommu/Makefile | 1 + > arch/arm64/include/asm/mmu.h | 1 + > arch/arm64/include/asm/mmu_context.h | 11 +- > drivers/iommu/io-pgtable-arm.h | 30 ++ > drivers/iommu/iommu-sva-lib.h | 15 + > include/linux/ioasid.h | 10 +- > include/linux/mm_types.h | 4 + > arch/arm64/kernel/cpufeature.c | 1 + > arch/arm64/mm/context.c | 95 +++- > drivers/iommu/arm-smmu-v3.c | 702 ++++++++++++++++++++++++++- > drivers/iommu/intel/iommu.c | 4 +- > drivers/iommu/intel/svm.c | 6 +- > drivers/iommu/io-pgtable-arm.c | 27 +- > drivers/iommu/ioasid.c | 38 +- > drivers/iommu/iommu-sva-lib.c | 85 ++++ > MAINTAINERS | 3 +- > 17 files changed, 977 insertions(+), 63 deletions(-) > create mode 100644 drivers/iommu/io-pgtable-arm.h > create mode 100644 drivers/iommu/iommu-sva-lib.h > create mode 100644 drivers/iommu/iommu-sva-lib.c > > -- > 2.27.0 >