From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B9BC433E0 for ; Thu, 9 Jul 2020 08:18:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 980942070E for ; Thu, 9 Jul 2020 08:18:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 980942070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F07F6B000E; Thu, 9 Jul 2020 04:18:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 379986B0010; Thu, 9 Jul 2020 04:18:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2687B6B0022; Thu, 9 Jul 2020 04:18:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id 1272E6B000E for ; Thu, 9 Jul 2020 04:18:17 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CC8398248D7C for ; Thu, 9 Jul 2020 08:18:16 +0000 (UTC) X-FDA: 77017834992.07.month73_480f66426ec4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 998D91803F9AD for ; Thu, 9 Jul 2020 08:18:16 +0000 (UTC) X-HE-Tag: month73_480f66426ec4 X-Filterd-Recvd-Size: 3998 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 08:18:16 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id o11so1349432wrv.9 for ; Thu, 09 Jul 2020 01:18:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sepqVQOjzQvJiSCh/8vOPtsthbitpZEiGbAn8HBa/z8=; b=Pc7hg0+nhD3sq4OPuJ/DzSC6VuVAKi6zJs/kh5kbw097P1cL7jiSuFZqPO+N4jJu29 cpXtiwZ6G2IJv5Q3l61w3eI3dZXgT6CVGcSV6KF4Tc6KtSiQOrYSZdPRGi+m2ImLybMO YlPQXQZaNV0VooYLLxLQiy+6UKnRkm0b1ACLTcQXyjCdIX/zMhfYr5cZ+jr5fv+Y+uhU isLdsxmScejVdXzPx90UxcMF+m2LPqW01UDbUVICA75q06A7B8Lh8YMg7o6wWYj2fqep v8K2SZfH/0XylRElkVsUT28tqlLtfB/mKJ9DrH+FcYa8s7NqlrJmAQeO6EA3BvUemjFE bZdA== X-Gm-Message-State: AOAM530dsPf+TNr+Mxhy/QGcyPfEdelevmBrI8Lvfiv2Mx/S//71Km9f d5RdHHzah2f5hBI2ay+9Ud0= X-Google-Smtp-Source: ABdhPJx1RzMKlSFTEJXpVfhAum9xG36F8crT8y5bzsVvjlBHnhyyn9NUEXp1RKb0byqUZDSXl9qUXw== X-Received: by 2002:adf:94a1:: with SMTP id 30mr31427064wrr.37.1594282695190; Thu, 09 Jul 2020 01:18:15 -0700 (PDT) Received: from localhost (ip-37-188-179-51.eurotel.cz. [37.188.179.51]) by smtp.gmail.com with ESMTPSA id k20sm3588934wmi.27.2020.07.09.01.18.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 01:18:14 -0700 (PDT) Date: Thu, 9 Jul 2020 10:18:13 +0200 From: Michal Hocko To: Yafang Shao Cc: Jonathan Corbet , Andrew Morton , David Rientjes , Linux MM , LKML Subject: Re: [PATCH 2/2] doc, mm: clarify /proc//oom_score value range Message-ID: <20200709081813.GD19160@dhcp22.suse.cz> References: <20200709062603.18480-1-mhocko@kernel.org> <20200709062603.18480-2-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 998D91803F9AD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 09-07-20 15:41:11, Yafang Shao wrote: > On Thu, Jul 9, 2020 at 2:26 PM Michal Hocko wrote: > > > > From: Michal Hocko > > > > The exported value includes oom_score_adj so the range is no [0, 1000] > > as described in the previous section but rather [0, 2000]. Mention that > > fact explicitly. > > > > Signed-off-by: Michal Hocko > > --- > > Documentation/filesystems/proc.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > > index 8e3b5dffcfa8..78a0dec323a3 100644 > > --- a/Documentation/filesystems/proc.rst > > +++ b/Documentation/filesystems/proc.rst > > @@ -1673,6 +1673,9 @@ requires CAP_SYS_RESOURCE. > > 3.2 /proc//oom_score - Display current oom-killer score > > ------------------------------------------------------------- > > > > +Please note that the exported value includes oom_score_adj so it is effectively > > +in range [0,2000]. > > + > > [0, 2000] may be not a proper range, see my reply in another thread.[1] > As this value hasn't been documented before and nobody notices that, I > think there might be no user really care about it before. > So we should discuss the proper range if we really think the user will > care about this value. Even if we decide the range should change, I do not really assume this will happen, it is good to have the existing behavior clarified. -- Michal Hocko SUSE Labs