From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9252C433DF for ; Tue, 7 Jul 2020 11:46:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 849E5206DF for ; Tue, 7 Jul 2020 11:46:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 849E5206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F05868D000E; Tue, 7 Jul 2020 07:46:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB61E8D000B; Tue, 7 Jul 2020 07:46:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCDE18D000E; Tue, 7 Jul 2020 07:46:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id C92018D000B for ; Tue, 7 Jul 2020 07:46:18 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4885A82499B9 for ; Tue, 7 Jul 2020 11:46:18 +0000 (UTC) X-FDA: 77011101636.19.house08_280122e26eb4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 110B81ACEA2 for ; Tue, 7 Jul 2020 11:46:18 +0000 (UTC) X-HE-Tag: house08_280122e26eb4 X-Filterd-Recvd-Size: 3624 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jul 2020 11:46:17 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id r12so44741331wrj.13 for ; Tue, 07 Jul 2020 04:46:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f/159hiHL9x+UhJssAcBn7P97Ay6xtu9/dua98ccUME=; b=dNX/P4HIAlpT8OYkRcLkQEc2eZjwkgtS1wfztGYM/QXHEgCHoBL+qrsOoOygjNadCc ztA2YrQOvPFGppmOnyOwPetGwOSTTz0jBZvNavj4b/B29IUkIHbDhV+b+9Oil0Dx96RS 9XPHXHbLISnHKfoEkWQXsNPi2rJK6evAnKVdqa/h1VPPf56+LfFfq9kncKUOwUhky0wB ydzAjl03g2QqnfHnXpO9SXlSJ/TWPfyqEbCMD0RNJPTu3Rs9sphK2Lh2vHkOZCwzUoGA tHOGc9/vHwswxiA2D/bIN0r4F2L6lzJqenwW8QcYdtLCLoplbpZaJKd6UQmvgBJ0nlRJ gg0g== X-Gm-Message-State: AOAM533k2f3SvB9IXp2Wy4/yefhupBu4/9kxa6LIBkFeZkfH/jU4KrxU D+CmB5ZwDXxrZmT8l6wODZk= X-Google-Smtp-Source: ABdhPJwWrp1UV1Z9J4yD0goAu88tpuwWxfZeWYe6XbPUzoatqpKrdAJbxwZ4gfj+G5hcm77R9Pa/YA== X-Received: by 2002:a5d:4b84:: with SMTP id b4mr56132552wrt.334.1594122376662; Tue, 07 Jul 2020 04:46:16 -0700 (PDT) Received: from localhost (ip-37-188-179-51.eurotel.cz. [37.188.179.51]) by smtp.gmail.com with ESMTPSA id b23sm824230wmd.37.2020.07.07.04.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 04:46:15 -0700 (PDT) Date: Tue, 7 Jul 2020 13:46:14 +0200 From: Michal Hocko To: js1304@gmail.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi , Joonsoo Kim Subject: Re: [PATCH v4 07/11] mm/gup: use a standard migration target allocation callback Message-ID: <20200707114614.GK5913@dhcp22.suse.cz> References: <1594107889-32228-1-git-send-email-iamjoonsoo.kim@lge.com> <1594107889-32228-8-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594107889-32228-8-git-send-email-iamjoonsoo.kim@lge.com> X-Rspamd-Queue-Id: 110B81ACEA2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 07-07-20 16:44:45, Joonsoo Kim wrote: [...] > @@ -1551,9 +1552,12 @@ struct page *alloc_migration_target(struct page *page, unsigned long private) > > gfp_mask |= htlb_alloc_mask(h); > return alloc_huge_page_nodemask(h, nid, mtc->nmask, > - gfp_mask, false); > + gfp_mask, mtc->skip_cma); > } > > + if (mtc->skip_cma) > + flags = memalloc_nocma_save(); > + As already mentioned in previous email this is a completely wrong usage of the scope API. The scope should be defined by the caller and this should be all transparent by the allocator layer. > if (PageTransHuge(page)) { > /* > * clear __GFP_RECALIM since GFP_TRANSHUGE is the gfp_mask > @@ -1572,6 +1576,9 @@ struct page *alloc_migration_target(struct page *page, unsigned long private) > if (new_page && PageTransHuge(new_page)) > prep_transhuge_page(new_page); > > + if (mtc->skip_cma) > + memalloc_nocma_restore(flags); > + > return new_page; > } > > -- > 2.7.4 -- Michal Hocko SUSE Labs