From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB343C433E0 for ; Tue, 7 Jul 2020 10:06:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9DAFF20708 for ; Tue, 7 Jul 2020 10:06:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DAFF20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F03456B006E; Tue, 7 Jul 2020 06:06:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E8DDA6B0071; Tue, 7 Jul 2020 06:06:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D540A6B0073; Tue, 7 Jul 2020 06:06:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id BB4F86B006E for ; Tue, 7 Jul 2020 06:06:22 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5D18B8248D7C for ; Tue, 7 Jul 2020 10:06:22 +0000 (UTC) X-FDA: 77010849804.23.route14_2108df926eb3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 2CD5E37608 for ; Tue, 7 Jul 2020 10:06:22 +0000 (UTC) X-HE-Tag: route14_2108df926eb3 X-Filterd-Recvd-Size: 4713 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jul 2020 10:06:21 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id b6so44493949wrs.11 for ; Tue, 07 Jul 2020 03:06:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=23vy72E5orNjWgQ+h1yoOH9UAR+rJOK6XwpQtfEVuLc=; b=qh4ZKGixJELb8Hkf8s4SI6d6jtxaIMFUoeIS1BSYVfADBUrQfr/Rh0Mm+i4wcZ3yl7 fFv3cfu+yeWMcM1aXnjS8xGJmwFnvduqGs1dcw24z5iB3wInu3FeT5kywJ1jKqbW6Huw bFiRcxRQGZ0rVaWnxcl6J3X3/LHd4s2mTFH7lWIL2/FIXE7dkZs5icKvii2u8IE9csdI aaQH6VuXpf51cUbOsn+dI2wIElH42GrbEuP/VxaZv3xh75ZvpsVsE5ZO065AdyFYplve ts+++01PWjWLfy2O9gbPjNstWCIJNeDivFel1fjRAljw1cQivdcadxDGwYiztXyER5fv 1gvQ== X-Gm-Message-State: AOAM533qfrH4idJORdEC2mUlBNZt7H7Luuf+BRA7H4fv67KAFDAy6Gir mCCh/TY96/yyQ8FraUoKfzE= X-Google-Smtp-Source: ABdhPJx0BB5CJ8IRPP7wZcpFAKcEtqcXu8b2tEnM5FooOgxWlc7cYpH2HfZCoJcvFlnV/vCsrbagEg== X-Received: by 2002:a5d:43d2:: with SMTP id v18mr52161392wrr.196.1594116379745; Tue, 07 Jul 2020 03:06:19 -0700 (PDT) Received: from localhost (ip-37-188-179-51.eurotel.cz. [37.188.179.51]) by smtp.gmail.com with ESMTPSA id d2sm279540wrs.95.2020.07.07.03.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 03:06:18 -0700 (PDT) Date: Tue, 7 Jul 2020 12:06:17 +0200 From: Michal Hocko To: Jia He Cc: Catalin Marinas , Will Deacon , Dan Williams , Vishal Verma , Dave Jiang , Andrew Morton , Mike Rapoport , Baoquan He , Chuhong Yuan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nvdimm@lists.01.org, Kaly Xin , stable@vger.kernel.org Subject: Re: [PATCH v2 3/3] mm/memory_hotplug: fix unpaired mem_hotplug_begin/done Message-ID: <20200707100617.GD5913@dhcp22.suse.cz> References: <20200707055917.143653-1-justin.he@arm.com> <20200707055917.143653-4-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707055917.143653-4-justin.he@arm.com> X-Rspamd-Queue-Id: 2CD5E37608 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 07-07-20 13:59:17, Jia He wrote: > When check_memblock_offlined_cb() returns failed rc(e.g. the memblock is > online at that time), mem_hotplug_begin/done is unpaired in such case. > > Therefore a warning: > Call Trace: > percpu_up_write+0x33/0x40 > try_remove_memory+0x66/0x120 > ? _cond_resched+0x19/0x30 > remove_memory+0x2b/0x40 > dev_dax_kmem_remove+0x36/0x72 [kmem] > device_release_driver_internal+0xf0/0x1c0 > device_release_driver+0x12/0x20 > bus_remove_device+0xe1/0x150 > device_del+0x17b/0x3e0 > unregister_dev_dax+0x29/0x60 > devm_action_release+0x15/0x20 > release_nodes+0x19a/0x1e0 > devres_release_all+0x3f/0x50 > device_release_driver_internal+0x100/0x1c0 > driver_detach+0x4c/0x8f > bus_remove_driver+0x5c/0xd0 > driver_unregister+0x31/0x50 > dax_pmem_exit+0x10/0xfe0 [dax_pmem] > > Fixes: f1037ec0cc8a ("mm/memory_hotplug: fix remove_memory() lockdep splat") > Cc: stable@vger.kernel.org # v5.6+ > Signed-off-by: Jia He Ups, I have missed that when reviewing that commit. Thanks for catching this up! Acked-by: Michal Hocko > --- > mm/memory_hotplug.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index da374cd3d45b..76c75a599da3 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1742,7 +1742,7 @@ static int __ref try_remove_memory(int nid, u64 start, u64 size) > */ > rc = walk_memory_blocks(start, size, NULL, check_memblock_offlined_cb); > if (rc) > - goto done; > + return rc; > > /* remove memmap entry */ > firmware_map_remove(start, start + size, "System RAM"); > @@ -1766,9 +1766,8 @@ static int __ref try_remove_memory(int nid, u64 start, u64 size) > > try_offline_node(nid); > > -done: > mem_hotplug_done(); > - return rc; > + return 0; > } > > /** > -- > 2.17.1 -- Michal Hocko SUSE Labs