From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5639C433E0 for ; Tue, 7 Jul 2020 03:14:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 45C81206E2 for ; Tue, 7 Jul 2020 03:14:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45C81206E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D7C256B0005; Mon, 6 Jul 2020 23:14:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2D6F6B0008; Mon, 6 Jul 2020 23:14:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C43586B000A; Mon, 6 Jul 2020 23:14:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id AEFCB6B0005 for ; Mon, 6 Jul 2020 23:14:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 503AB8248047 for ; Tue, 7 Jul 2020 03:14:04 +0000 (UTC) X-FDA: 77009810808.18.sack30_1f0561026eb1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 25553100EDBC1 for ; Tue, 7 Jul 2020 03:14:04 +0000 (UTC) X-HE-Tag: sack30_1f0561026eb1 X-Filterd-Recvd-Size: 2788 Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jul 2020 03:14:03 +0000 (UTC) Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 05D4362912129E933CDC; Tue, 7 Jul 2020 11:13:57 +0800 (CST) Received: from SWX921481.china.huawei.com (10.126.201.228) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Tue, 7 Jul 2020 11:13:48 +0800 From: Barry Song To: CC: , , , Barry Song , "Roman Gushchin" , Mike Kravetz , "Jonathan Cameron" Subject: [PATCH v2] mm/hugetlb: avoid hardcoding while checking if cma is enable Date: Tue, 7 Jul 2020 15:11:56 +1200 Message-ID: <20200707031156.29932-1-song.bao.hua@hisilicon.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.126.201.228] X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 25553100EDBC1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: hugetlb_cma[0] can be NULL due to various reasons, for example, node0 has no memory. so NULL hugetlb_cma[0] doesn't necessarily mean cma is not enabled. gigantic pages might have been reserved on other nodes. Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages= using cma") Cc: Roman Gushchin Cc: Mike Kravetz Cc: Jonathan Cameron Signed-off-by: Barry Song --- -v2: add hugetlb_cma_enabled() helper to improve readability according t= o Roman mm/hugetlb.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 57ece74e3aae..d5e98ed86bb9 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2546,6 +2546,20 @@ static void __init gather_bootmem_prealloc(void) } } =20 +bool __init hugetlb_cma_enabled(void) +{ + if (IS_ENABLED(CONFIG_CMA)) { + int node; + + for_each_online_node(node) { + if (hugetlb_cma[node]) + return true; + } + } + + return false; +} + static void __init hugetlb_hstate_alloc_pages(struct hstate *h) { unsigned long i; @@ -2571,7 +2585,7 @@ static void __init hugetlb_hstate_alloc_pages(struc= t hstate *h) =20 for (i =3D 0; i < h->max_huge_pages; ++i) { if (hstate_is_gigantic(h)) { - if (IS_ENABLED(CONFIG_CMA) && hugetlb_cma[0]) { + if (hugetlb_cma_enabled()) { pr_warn_once("HugeTLB: hugetlb_cma is enabled, skip boot time alloca= tion\n"); break; } --=20 2.27.0