From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96E2BC433E1 for ; Mon, 6 Jul 2020 14:59:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 59CE620715 for ; Mon, 6 Jul 2020 14:59:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LUmTPMf5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59CE620715 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 985376B0006; Mon, 6 Jul 2020 10:59:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 937056B0007; Mon, 6 Jul 2020 10:59:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84BA66B0008; Mon, 6 Jul 2020 10:59:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 6EDE06B0006 for ; Mon, 6 Jul 2020 10:59:02 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 12CCF1EE6 for ; Mon, 6 Jul 2020 14:59:02 +0000 (UTC) X-FDA: 77007958524.19.bikes21_1e109bd26eac Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id CF05F1AD1B9 for ; Mon, 6 Jul 2020 14:59:01 +0000 (UTC) X-HE-Tag: bikes21_1e109bd26eac X-Filterd-Recvd-Size: 3916 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Jul 2020 14:59:01 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id e12so29126924qtr.9 for ; Mon, 06 Jul 2020 07:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ry1RpVAEDjDLCs5jpWgNEsfeNNgUahwX2prGBgFkAOU=; b=LUmTPMf5mmAgukBOW1BCsZ9FagomTLGbESXBWtoa2RJ2ZwucTPRq7Ri2KvyQA/HpHa 8pizs6iLDVo4+l+zATwQAGnjVXzSREMVSfWd837YEhQYD/KxIDaoNhKsH6ag/zcswwiR +v6Ic4Apb8Kaa7aYzWJEhhB+QhWa2ZAu2TXd6wdbojP4fiBQq+AUNtU4H5SfFNRRVwnm on/C1L8EToHj1d75h8Utb+WKCzRpavTBd4+cVa3cSF8zqxef/X8c6Gs4Mbr/J1TiBu4t pWEpbTQ/fsQzZ/hzBlyEkAc26KWRTQSRTFd46GJIIlLj+f3CDf4NDOH+KJ9bSnFIoUz6 PFUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=Ry1RpVAEDjDLCs5jpWgNEsfeNNgUahwX2prGBgFkAOU=; b=N6n1JRUrFZCAyKzRPg53pcuSVqof7bICXYPnUJ9cxv6ntEdGa3eKMHzV2J8cwf3eMu TADkZg8CFRW8USEeZL/zmtmNHqaAcpw0CQj8OJVLBz+FEzhfsxWc+olyPGpfnEMyo6bd ffeMC7n1aOwK2fdg2GmyQaCc0RxvxiG5q1HfEARMLBwIAdEi1HNxasIS9/TbGD1gTWV9 kOpylLbwKeivOfW2bMVzqY8oiYGSZjgkesmj0sGEVBkiv0CYkAXzsf2+GEvfWuPjpdlK QCapMlSEenIUwr7cG5gG4+SKYtQLhrJLcfhXRtDx/6swj3/xSjmci+9Fd5TQyE/1IQFQ BbKA== X-Gm-Message-State: AOAM530nSnVxyDahvtfGF0e7uRPOdUX34cFEJ2Pb/5HB7W2szVBamRTp 4SYrvfVcOr07BSF8T24ORMk= X-Google-Smtp-Source: ABdhPJykggZDIAVAXmRbeYWXuLMu3UvItgKVCCxVjen0/4GBZzuzIGAZmQgjrGUyGZjMwcuf9HP87w== X-Received: by 2002:aed:239b:: with SMTP id j27mr50809330qtc.183.1594047540521; Mon, 06 Jul 2020 07:59:00 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:74c4]) by smtp.gmail.com with ESMTPSA id c27sm18469834qkl.125.2020.07.06.07.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 07:58:59 -0700 (PDT) Date: Mon, 6 Jul 2020 10:58:58 -0400 From: Tejun Heo To: Chengguang Xu Cc: akpm@linux-foundation.org, stable@vger.kernel.org, dxu@dxuuu.xyz, chris@chrisdown.name, adilger@dilger.ca, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, hughd@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2] vfs/xattr: mm/shmem: kernfs: release simple xattr entry in a right way Message-ID: <20200706145858.GA5603@mtj.thefacebook.com> References: <20200704051608.15043-1-cgxu519@mykernel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200704051608.15043-1-cgxu519@mykernel.net> X-Rspamd-Queue-Id: CF05F1AD1B9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 04, 2020 at 01:16:08PM +0800, Chengguang Xu wrote: > After commit fdc85222d58e ("kernfs: kvmalloc xattr value > instead of kmalloc"), simple xattr entry is allocated with > kvmalloc() instead of kmalloc(), so we should release it > with kvfree() instead of kfree(). > > Cc: stable@vger.kernel.org # v5.7 > Cc: Daniel Xu > Cc: Chris Down > Cc: Andreas Dilger > Cc: Greg Kroah-Hartman > Cc: Tejun Heo > Cc: Al Viro > Cc: Hugh Dickins > Fixes: fdc85222d58e ("kernfs: kvmalloc xattr value instead of kmalloc") > Signed-off-by: Chengguang Xu Acked-by: Tejun Heo Thanks. -- tejun