From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D8BC433E0 for ; Mon, 6 Jul 2020 10:08:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0691720739 for ; Mon, 6 Jul 2020 10:08:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="vB/nvAwt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0691720739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB70D6B000A; Mon, 6 Jul 2020 06:08:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3F876B000D; Mon, 6 Jul 2020 06:08:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908956B000E; Mon, 6 Jul 2020 06:08:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0204.hostedemail.com [216.40.44.204]) by kanga.kvack.org (Postfix) with ESMTP id 7B7136B000A for ; Mon, 6 Jul 2020 06:08:21 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 48F1B8248047 for ; Mon, 6 Jul 2020 10:08:21 +0000 (UTC) X-FDA: 77007226002.10.sugar00_4f13fc526eab Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 17CAD16A07E for ; Mon, 6 Jul 2020 10:08:21 +0000 (UTC) X-HE-Tag: sugar00_4f13fc526eab X-Filterd-Recvd-Size: 3997 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Jul 2020 10:08:20 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id b25so40970686ljp.6 for ; Mon, 06 Jul 2020 03:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kGb++Oj9rl3Cq6rtcCZ3Q51WnJpX5i2BfarNm4RLaXQ=; b=vB/nvAwt42ueZDWAJ17ouUoS6PUXx9gV9fQr0d213CkbXYjCbXcyPuXXir6YlKSj+6 mtlaD9hmfMaCdwkeH8PIQb5H7dUWTfkCPBEoBISCHhvPQkUWItV/t2tE9XpGsNf67IRN 5J/qUUiJIwD0o3Peq5xFHUaI/xqSHoxKdCCdERWkuyM+cn7SZgip7nLJpBUPtfMVS0jp kjqY8oWs79Pcli1FKp1UqAG/yb0MXhUILIEBWw3y39Ux7zv4OxKmZe4Fhfo8Q7Gdoeyh o3L8h6XSo7dipq+GodOdsvgQp/nd8RLir9rL/ybenanpxw3/nR33Yb6Hs5GLOm4VxRIM xOXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kGb++Oj9rl3Cq6rtcCZ3Q51WnJpX5i2BfarNm4RLaXQ=; b=Ilt4S47cQXAZqiY+eeG8rQdi79dvB/JThEo8RpR4PpujQlDCnmX6ItTISU6XU808a0 jK78yedWor/UO/Cp/jRalNiFetrOOUWHu1wnEQZ72v0AGYF6KWE9YuRFo9dCnT0xT+5g HpidjibTfnomrEE2yBxRVjLZOYXPPjm9GlI74Rjg7I534w2ux/wPK1eAqIfy2Mo74dzz Yc6RSFy6uaJlnXiyENTqMDSp5NW/Sg2/PVq4JctofCy6ElJcIUoxmcoFSAS+nwQZdgSs N0T54e3i3mH7zswPoJ3Lo+7d1GQM3mJjZKiV5CcMLLK4yAkvYmo86IMacYoGG8WkXw3r y8eA== X-Gm-Message-State: AOAM531+9cgmSJsZg5yqWSZk/7zLdzy0Pdt4vBlZwWy+STE+7PYFgAy6 5UA6/kDoFGWig2JUwDRxRCeISA== X-Google-Smtp-Source: ABdhPJyLhQdDzhBS4eUh9v56575OycEkKyAgGdWCb0ZinjOPHLYjK5/5dNC8R7jurOvD6vvMoUA5Nw== X-Received: by 2002:a05:651c:1105:: with SMTP id d5mr15181275ljo.62.1594030099343; Mon, 06 Jul 2020 03:08:19 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id l4sm3962327ljc.83.2020.07.06.03.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 03:08:18 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 489EA10220C; Mon, 6 Jul 2020 13:08:19 +0300 (+03) Date: Mon, 6 Jul 2020 13:08:19 +0300 From: "Kirill A. Shutemov" To: Wei Yang Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, yang.shi@linux.alibaba.com, vbabka@suse.cz, willy@infradead.org, thomas_os@shipmail.org, thellstrom@vmware.com, anshuman.khandual@arm.com, sean.j.christopherson@intel.com, aneesh.kumar@linux.ibm.com, peterx@redhat.com, walken@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, digetx@gmail.com Subject: Re: [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Message-ID: <20200706100819.flwgozlstn3zl66u@box> References: <20200626135216.24314-1-richard.weiyang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626135216.24314-1-richard.weiyang@linux.alibaba.com> X-Rspamd-Queue-Id: 17CAD16A07E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 26, 2020 at 09:52:12PM +0800, Wei Yang wrote: > move_page_tables() tries to move page table by PMD or PTE. > > The root reason is if it tries to move PMD, both old and new range should be > PMD aligned. But current code calculate old range and new range separately. > This leads to some redundant check and calculation. > > This cleanup tries to consolidate the range check in one place to reduce some > extra range handling. The patchet looks good to me. I have few nits, but nothing substantial. Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov