From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD842C433E0 for ; Mon, 6 Jul 2020 10:06:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6BCA820739 for ; Mon, 6 Jul 2020 10:06:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="aZOSy7jO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BCA820739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E5FDB6B0003; Mon, 6 Jul 2020 06:06:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E106A6B0007; Mon, 6 Jul 2020 06:06:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D286A6B000A; Mon, 6 Jul 2020 06:06:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id BF9206B0003 for ; Mon, 6 Jul 2020 06:06:28 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 689361EE6 for ; Mon, 6 Jul 2020 10:06:28 +0000 (UTC) X-FDA: 77007221256.13.wool41_07158ef26eaa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 3AF3E18140B70 for ; Mon, 6 Jul 2020 10:06:28 +0000 (UTC) X-HE-Tag: wool41_07158ef26eaa X-Filterd-Recvd-Size: 3749 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Jul 2020 10:06:27 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id o4so22235863lfi.7 for ; Mon, 06 Jul 2020 03:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VIy1PYFvSGV4F/y0iGsUNRz/f+oDEDfZZt7Xzd1mAQw=; b=aZOSy7jO/RQMl3lqs6m9IcJVXUAAa3tjv9H9pSIm0grp0B35UwL8mtd69hePoWofuz M5C6MVjlDmSI7x/dOKmKkAABK/LnK8HEJ4ShXaQeiph6ye9diF8guf0qNu7xqZmfoXyl zbgB+BnZx9gS8a3rJ74IiVxp7pLVJdmCo43frloEsrcZiod4TAYoDZlekkCkjcxgV64J 9HoKzMWND4+xK63KzI+IEwUc/12vhLOSXKI9/uStvVKc9w6U3DfTI3BcbueRI9B3z0Ll 2Cm72ARNpUpoV1AOiGQVtSyi0LJGYb7xqUj/jJIZvfNGazCTaiCJDTJqP9FgB/0GIpsN munw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VIy1PYFvSGV4F/y0iGsUNRz/f+oDEDfZZt7Xzd1mAQw=; b=FaPjczP6+nYckp/g+r3YfbtM7zFXRyKzNJSNmibcaq+Za7yDM3KWg3h8a2K+UEaf4u CdmP3fEpnj0utEvdZVBjP7pidDYYYHvXmoYaFF/NTlorENRZgLHMhnDBem3AEhEO+YwO c0yGqv0qJEK3fKxC0JXVyfstNX1s8UeMhnGIDfkxX76zhFxfbXUXC+Li1ANuL0YVrgaD Xv2bOqqWX1GgX7L8IEkcl70NGyQAfx1YkAAVYixcAY4v19/w7hQ6BWonFeazUDL9TNED 03jAez31bGH3dReLoU67ZspyP/qrbynzeivmOHe/hmYYJn8SI1CiTTuA/tKPg7Rx3Kys yO2g== X-Gm-Message-State: AOAM532pYYb13sAdcgy5R9urjlVLECPXzBukscCZJsF0l9yMNiLHf/z/ bXN8zj+xDOsFOmObhg5kJOSTgw== X-Google-Smtp-Source: ABdhPJzT2D7wioGEbB2zTH7RUm4yrbl9kADwLsMGQa9kouT4Ky4/Ih+Ee54x09/RRzXMGgC3fuDRAw== X-Received: by 2002:ac2:4422:: with SMTP id w2mr29362578lfl.152.1594029986326; Mon, 06 Jul 2020 03:06:26 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id m9sm8811917lfb.5.2020.07.06.03.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 03:06:25 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id D810310220C; Mon, 6 Jul 2020 13:06:25 +0300 (+03) Date: Mon, 6 Jul 2020 13:06:25 +0300 From: "Kirill A. Shutemov" To: Wei Yang Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, yang.shi@linux.alibaba.com, vbabka@suse.cz, willy@infradead.org, thomas_os@shipmail.org, thellstrom@vmware.com, anshuman.khandual@arm.com, sean.j.christopherson@intel.com, aneesh.kumar@linux.ibm.com, peterx@redhat.com, walken@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, digetx@gmail.com Subject: Re: [RESEND Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd() Message-ID: <20200706100625.nxh5hd4m6rremzyt@box> References: <20200626135216.24314-1-richard.weiyang@linux.alibaba.com> <20200626135216.24314-2-richard.weiyang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626135216.24314-2-richard.weiyang@linux.alibaba.com> X-Rspamd-Queue-Id: 3AF3E18140B70 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 26, 2020 at 09:52:13PM +0800, Wei Yang wrote: > No functional change, just improve the readability and prepare for > following cleanup. It's pretty much redundant. It doesn't provide any meaningful readability improvement. Please drop the patch. -- Kirill A. Shutemov