From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A6CC433DF for ; Fri, 3 Jul 2020 19:20:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 72B6820899 for ; Fri, 3 Jul 2020 19:20:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="rhyR5gjh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72B6820899 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D2CF58D0083; Fri, 3 Jul 2020 15:20:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDDD18D0030; Fri, 3 Jul 2020 15:20:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF4378D0083; Fri, 3 Jul 2020 15:20:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id AA4D68D0030 for ; Fri, 3 Jul 2020 15:20:45 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 23FB0181AC9C6 for ; Fri, 3 Jul 2020 19:20:45 +0000 (UTC) X-FDA: 76997731650.04.car69_3b0a82c26e94 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id F1A628005022 for ; Fri, 3 Jul 2020 19:20:44 +0000 (UTC) X-HE-Tag: car69_3b0a82c26e94 X-Filterd-Recvd-Size: 2047 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 19:20:44 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98B27207FF; Fri, 3 Jul 2020 19:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593804043; bh=DcI36x1KbB5MC5jc3R2XQkLwZK4wbksYIBgQwes31L0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rhyR5gjhDSRZ0PtX/HlYAofvo2rDouaaxTLX2vQVgwyK5UFOmr5rWUQKt7bZMlQsh 9PYqzpR7+VJCQqiGUdwo21ez1gOD64A90GOvRr2K5ySMDFdQ1b3SQ2/RWFM31vp2jx vAkThMB0Wh+Fw2tt2MiC3H4p1qfrGGfKKPJzYUjE= Date: Fri, 3 Jul 2020 12:20:43 -0700 From: Andrew Morton To: Chengguang Xu Cc: hughd@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/shmem: fix freeing new_attr in shmem_initxattrs() Message-Id: <20200703122043.c931cf9e0c85878ccc4e53f1@linux-foundation.org> In-Reply-To: <20200703065636.20897-1-cgxu519@mykernel.net> References: <20200703065636.20897-1-cgxu519@mykernel.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F1A628005022 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Jul 2020 14:56:36 +0800 Chengguang Xu wrote: > new_attr is allocated with kvmalloc() so should be freed > with kvfree(). > > ... > > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3178,7 +3178,7 @@ static int shmem_initxattrs(struct inode *inode, > new_xattr->name = kmalloc(XATTR_SECURITY_PREFIX_LEN + len, > GFP_KERNEL); > if (!new_xattr->name) { > - kfree(new_xattr); > + kvfree(new_xattr); > return -ENOMEM; > } Indeed. Maybe simple_xattr_alloc() should have been called simple_xattr_kvmalloc().