From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3729C433E0 for ; Fri, 3 Jul 2020 00:53:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA0FE20884 for ; Fri, 3 Jul 2020 00:53:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eC8THW9g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA0FE20884 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5CC988D0019; Thu, 2 Jul 2020 20:53:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 556E68D0002; Thu, 2 Jul 2020 20:53:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 444718D0019; Thu, 2 Jul 2020 20:53:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 2A8658D0002 for ; Thu, 2 Jul 2020 20:53:04 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D759552D0 for ; Fri, 3 Jul 2020 00:53:03 +0000 (UTC) X-FDA: 76994940246.21.fact68_16057d826e8d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id B6293180442C0 for ; Fri, 3 Jul 2020 00:53:03 +0000 (UTC) X-HE-Tag: fact68_16057d826e8d X-Filterd-Recvd-Size: 6356 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 00:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593737582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CULJFp+mODjg6iHDkj5D4GeB51UD2IHVmmu+m4v/Di4=; b=eC8THW9g7MZOVn/PacFB3fbHe5HWRw5drt384gUKNHT4FTkFA2l0rcCDPeIfQ0sFzTJbXb d8yt3r8Di5LbJfnC60wEEYC6JYq7up7eTjLAxRkdF4WpQzmkxvKyW2Zuosm+0AYpD4KrwY ineVwbSlmR8iGalHS0tT2vRjZ8x7byU= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-5bp9f4QiOQasPCWMpef6vA-1; Thu, 02 Jul 2020 20:52:58 -0400 X-MC-Unique: 5bp9f4QiOQasPCWMpef6vA-1 Received: by mail-qt1-f200.google.com with SMTP id e4so20639055qtd.13 for ; Thu, 02 Jul 2020 17:52:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CULJFp+mODjg6iHDkj5D4GeB51UD2IHVmmu+m4v/Di4=; b=aQcu0TOxWRhTUH4ygRtKpF44LPPe3q1Hr2rCKNDTEnFoRIqvUf7JPTSxDFmM6CYyVI XqFci48QHTitx0Ie9C7P2cHTny4fTM1ZBHwwrft/ODXvJ8ap2G1jfyDABxT7yLuan2eu RNVENys/6HWOUUjVrQn7/rmn7q7gno5ubI/7oA2Q7LHMLUOYseZp/FnrAmyPsycU5/WJ +eZBFIcT53fAcXVzUzVrz8ZeE/4Ua0Uog4TN6lGFYac0TRed/iXlm5y+KOJc8M2XuI5H kqxZ4LD7GBC2guwFRCUb1sqNVBbYlUMr/RSEyb8gAhNsEpcyLS7CGsTcKuM7eSXNdGU4 b0GQ== X-Gm-Message-State: AOAM531ECHPSZUdDNYHU8ZsDpJYUE5D84L5bUyKGG45Wp+F7eX32SLyy jjKoKsU1Knfhr5u2DdIa2MZKja1UjWBmP2dYi8+3F64H+h5SIuDjOgQBHwkdtvJ2yEiSIqU1KuU Foh2IdYZ2wGE= X-Received: by 2002:a0c:fb47:: with SMTP id b7mr22636073qvq.129.1593737578212; Thu, 02 Jul 2020 17:52:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyP1HYu8QJN62LP6dFLsqmw311h2Hp3lgkh95q++LJEn0WZi0TPW5UqaXSPu8EngNu1OXf2/g== X-Received: by 2002:a0c:fb47:: with SMTP id b7mr22636058qvq.129.1593737577992; Thu, 02 Jul 2020 17:52:57 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id j9sm9602885qtr.60.2020.07.02.17.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 17:52:57 -0700 (PDT) Date: Thu, 2 Jul 2020 20:52:55 -0400 From: Peter Xu To: John Hubbard Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Michael Ellerman , Gerald Schaefer , Andrea Arcangeli , Linus Torvalds , Will Deacon Subject: Re: [PATCH v4 26/26] mm/gup: Remove task_struct pointer for all gup code Message-ID: <20200703005255.GB6677@xz-x1> References: <20200630204609.39736-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: B6293180442C0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 01, 2020 at 02:55:40PM -0700, John Hubbard wrote: > On 2020-06-30 13:46, Peter Xu wrote: > > After the cleanup of page fault accounting, gup does not need to pass > > task_struct around any more. Remove that parameter in the whole gup stack. > > > > Signed-off-by: Peter Xu > > --- > > arch/arc/kernel/process.c | 2 +- > > arch/s390/kvm/interrupt.c | 2 +- > > arch/s390/kvm/kvm-s390.c | 2 +- > > arch/s390/kvm/priv.c | 8 +- > > arch/s390/mm/gmap.c | 4 +- > > drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 2 +- > > drivers/infiniband/core/umem_odp.c | 2 +- > > drivers/vfio/vfio_iommu_type1.c | 4 +- > > fs/exec.c | 2 +- > > include/linux/mm.h | 9 +- > > kernel/events/uprobes.c | 6 +- > > kernel/futex.c | 2 +- > > mm/gup.c | 92 +++++++++------------ > > mm/memory.c | 2 +- > > mm/process_vm_access.c | 2 +- > > security/tomoyo/domain.c | 2 +- > > virt/kvm/async_pf.c | 2 +- > > virt/kvm/kvm_main.c | 2 +- > > 18 files changed, 65 insertions(+), 82 deletions(-) > > > > Looks good: > > Reviewed-by: John Hubbard > > One minor refinement: in gup.c, if you add the following hunk on top of your > changes, that will eradicate the last reference to struct task, in that file: > > > diff --git a/mm/gup.c b/mm/gup.c > index 8ddc48022d74..75c4b305828b 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1902,10 +1902,9 @@ static long __get_user_pages_remote(struct mm_struct *mm, > * Or NULL if the caller does not require them. > * > * This is the same as get_user_pages_remote(), just with a > - * less-flexible calling convention where we assume that the task > - * and mm being operated on are the current task's and don't allow > - * passing of a locked parameter. We also obviously don't pass > - * FOLL_REMOTE in here. > + * less-flexible calling convention where we assume that the mm being operated > + * on belongs to the current task, and doesn't allow passing of a locked > + * parameter. We also obviously don't pass FOLL_REMOTE in here. > */ > long get_user_pages(unsigned long start, unsigned long nr_pages, > unsigned int gup_flags, struct page **pages, Right. Fixed it up, and with the r-b kept. Thanks! -- Peter Xu