From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F27DC433DF for ; Thu, 2 Jul 2020 15:51:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A83120771 for ; Thu, 2 Jul 2020 15:51:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KwkXyg8B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A83120771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CDAD06B00DC; Thu, 2 Jul 2020 11:51:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8A456B00E0; Thu, 2 Jul 2020 11:51:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B52EA6B00E1; Thu, 2 Jul 2020 11:51:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0183.hostedemail.com [216.40.44.183]) by kanga.kvack.org (Postfix) with ESMTP id 9D4246B00DC for ; Thu, 2 Jul 2020 11:51:43 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 154FB181AC9BF for ; Thu, 2 Jul 2020 15:51:43 +0000 (UTC) X-FDA: 76993576086.03.cart45_6004f0d26e8a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id C7DDF28A240 for ; Thu, 2 Jul 2020 15:51:42 +0000 (UTC) X-HE-Tag: cart45_6004f0d26e8a X-Filterd-Recvd-Size: 4591 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Thu, 2 Jul 2020 15:51:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593705101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3VZY2zDbwBbzLtxgPU26SXjP7JkefPkdEkB2jqODvmQ=; b=KwkXyg8BVGRrJN0V80RC+po/6uz89TLC4CbAK90SXEo7BYnBne2iOaWqXTQGADy4Vdc+Rn XLNDDOQ4JCuL5C/0elnvjK54Yd4dhYlyBAwhmS820Mv3zWrKCaPHS8Rycq6gJFevried0r hv6AaRv7VIPekB6elP8vEM36iuXYvDk= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-r_vBb3VaPFG9MKrSroYTZQ-1; Thu, 02 Jul 2020 11:51:36 -0400 X-MC-Unique: r_vBb3VaPFG9MKrSroYTZQ-1 Received: by mail-qv1-f70.google.com with SMTP id bk16so18615604qvb.11 for ; Thu, 02 Jul 2020 08:51:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3VZY2zDbwBbzLtxgPU26SXjP7JkefPkdEkB2jqODvmQ=; b=WdSKAKVij6NChMEiNaAFXa65qOL/yf5hMD4cZhq0VUAxqQoeDyqtsk20TUxEYCxx7I 2gVWdSb3l37E7qF1JxuWJ1P5gkSFW30zY99E+bJEJ88BpCg2daHfbVpLBY6wAuuwhLow IGKdUyZ2rceRndxgiyNAwCb8yBmhBjcLbI0Qoy//77cW9YdI/CQSUiczbui83QD31nHS m6KKuRQe9okM6npGGZNtlD4jB7W2MMtBLWyW6GjFYgBGevJ8oChuVAV0gsy74878J4AM 61i2ioKqZESTMd/8entktnbwQPam6CG66nCI2WpeuH0gxnAWBEUA9LN+JQI6sskInc+n vVWg== X-Gm-Message-State: AOAM530yaE5NRSOV7/zsbQHfnrJ3PM4gecu9lwkaZfhSnTYDwWiQ+LEO yMR5rQq8wy4XrHn7FSEbwUPWfDANbS5cIAzLB7qosy6MawMhHx19b4qE8l5oqzuisXB6eKsi3d2 wzq0mwUOZ57I= X-Received: by 2002:a37:5bc4:: with SMTP id p187mr31620571qkb.166.1593705095717; Thu, 02 Jul 2020 08:51:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKAr0yUH8hYYhDsr4DruYkVLRU9FgSh469c3MauYeix84ykqUuFOOZU7bgix90YvCz9q//0g== X-Received: by 2002:a37:5bc4:: with SMTP id p187mr31620555qkb.166.1593705095513; Thu, 02 Jul 2020 08:51:35 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id x13sm8044078qts.57.2020.07.02.08.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 08:51:33 -0700 (PDT) Date: Thu, 2 Jul 2020 11:51:32 -0400 From: Peter Xu To: Pekka Enberg Cc: "linux-mm@kvack.org" , LKML , Andrew Morton , Linus Torvalds , Gerald Schaefer , Andrea Arcangeli , Will Deacon , Michael Ellerman , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org Subject: Re: [PATCH 17/26] mm/riscv: Use general page fault accounting Message-ID: <20200702155132.GJ40675@xz-x1> References: <20200626223130.199227-1-peterx@redhat.com> <20200626223625.199813-1-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: C7DDF28A240 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 01, 2020 at 02:46:24PM +0300, Pekka Enberg wrote: > Hi Peter, Hi, Pekka, > > On Sat, Jun 27, 2020 at 1:36 AM Peter Xu wrote: > > Use the general page fault accounting by passing regs into handle_mm_fault(). > > It naturally solve the issue of multiple page fault accounting when page fault > > retry happened. > > I sent a patch to fix up riscv page fault accounting some days ago: > > http://lists.infradead.org/pipermail/linux-riscv/2020-June/000775.html Yes, this is a valid fix too. > > However, your fix is obviously even better. For the generic and riscv parts: > > Reviewed-by: Pekka Enberg Thanks! -- Peter Xu