From: Dave Hansen <dave.hansen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org,Dave Hansen
<dave.hansen@linux.intel.com>,ben.widawsky@intel.com,alex.shi@linux.alibaba.com,dwagner@suse.de,tobin@kernel.org,cl@linux.com,akpm@linux-foundation.org,ying.huang@intel.com,dan.j.williams@intel.com,cai@lca.pw
Subject: [PATCH 2/3] mm/vmscan: move RECLAIM* bits to uapi header
Date: Wed, 01 Jul 2020 08:26:24 -0700 [thread overview]
Message-ID: <20200701152624.D6FBDDA8@viggo.jf.intel.com> (raw)
In-Reply-To: <20200701152621.D520E62B@viggo.jf.intel.com>
From: Dave Hansen <dave.hansen@linux.intel.com>
It is currently not obvious that the RECLAIM_* bits are part of the
uapi since they are defined in vmscan.c. Move them to a uapi header
to make it obvious.
This should have no functional impact.
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Ben Widawsky <ben.widawsky@intel.com>
Cc: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Daniel Wagner <dwagner@suse.de>
Cc: "Tobin C. Harding" <tobin@kernel.org>
Cc: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Qian Cai <cai@lca.pw>
Cc: Daniel Wagner <dwagner@suse.de>
--
Note: This is not cc'd to stable. It does not fix any bugs.
---
b/include/uapi/linux/mempolicy.h | 7 +++++++
b/mm/vmscan.c | 8 --------
2 files changed, 7 insertions(+), 8 deletions(-)
diff -puN include/uapi/linux/mempolicy.h~mm-vmscan-move-RECLAIM-bits-to-uapi include/uapi/linux/mempolicy.h
--- a/include/uapi/linux/mempolicy.h~mm-vmscan-move-RECLAIM-bits-to-uapi 2020-07-01 08:22:12.502955333 -0700
+++ b/include/uapi/linux/mempolicy.h 2020-07-01 08:22:12.508955333 -0700
@@ -62,5 +62,12 @@ enum {
#define MPOL_F_MOF (1 << 3) /* this policy wants migrate on fault */
#define MPOL_F_MORON (1 << 4) /* Migrate On protnone Reference On Node */
+/*
+ * These bit locations are exposed in the vm.zone_reclaim_mode sysctl
+ * ABI. New bits are OK, but existing bits can never change.
+ */
+#define RECLAIM_ZONE (1<<0) /* Run shrink_inactive_list on the zone */
+#define RECLAIM_WRITE (1<<1) /* Writeout pages during reclaim */
+#define RECLAIM_UNMAP (1<<2) /* Unmap pages during reclaim */
#endif /* _UAPI_LINUX_MEMPOLICY_H */
diff -puN mm/vmscan.c~mm-vmscan-move-RECLAIM-bits-to-uapi mm/vmscan.c
--- a/mm/vmscan.c~mm-vmscan-move-RECLAIM-bits-to-uapi 2020-07-01 08:22:12.504955333 -0700
+++ b/mm/vmscan.c 2020-07-01 08:22:12.509955333 -0700
@@ -4091,14 +4091,6 @@ module_init(kswapd_init)
int node_reclaim_mode __read_mostly;
/*
- * These bit locations are exposed in the vm.zone_reclaim_mode sysctl
- * ABI. New bits are OK, but existing bits can never change.
- */
-#define RECLAIM_ZONE (1<<0) /* Run shrink_inactive_list on the zone */
-#define RECLAIM_WRITE (1<<1) /* Writeout pages during reclaim */
-#define RECLAIM_UNMAP (1<<2) /* Unmap pages during reclaim */
-
-/*
* Priority for NODE_RECLAIM. This determines the fraction of pages
* of a node considered for each zone_reclaim. 4 scans 1/16th of
* a zone.
_
next prev parent reply other threads:[~2020-07-01 15:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 15:26 [PATCH 0/3] [v2] Repair and clean up vm.zone_reclaim_mode sysctl ABI Dave Hansen
2020-07-01 15:26 ` [PATCH 1/3] mm/vmscan: restore zone_reclaim_mode ABI Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-02 11:28 ` Huang, Ying
2020-07-02 14:36 ` Dave Hansen
2020-07-01 15:26 ` Dave Hansen [this message]
2020-07-01 15:46 ` [PATCH 2/3] mm/vmscan: move RECLAIM* bits to uapi header Ben Widawsky
2020-07-01 15:56 ` Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-01 15:26 ` [PATCH 3/3] mm/vmscan: replace implicit RECLAIM_ZONE checks with explicit checks Dave Hansen
2020-07-01 20:03 ` David Rientjes
2020-07-01 20:04 ` Ben Widawsky
2020-07-01 21:29 ` Dave Hansen
2020-07-01 22:01 ` David Rientjes
2020-07-01 16:00 ` [PATCH 0/3] [v2] Repair and clean up vm.zone_reclaim_mode sysctl ABI Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701152624.D6FBDDA8@viggo.jf.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=ben.widawsky@intel.com \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tobin@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox