From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D302C433E2 for ; Wed, 1 Jul 2020 01:33:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F403D20771 for ; Wed, 1 Jul 2020 01:33:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tygY2kWV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F403D20771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 711BA6B00A8; Tue, 30 Jun 2020 21:33:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 699006B00A9; Tue, 30 Jun 2020 21:33:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 561CB6B00AA; Tue, 30 Jun 2020 21:33:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 3C64C6B00A8 for ; Tue, 30 Jun 2020 21:33:58 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C177F180AD801 for ; Wed, 1 Jul 2020 01:33:57 +0000 (UTC) X-FDA: 76987785714.29.wren59_4b06a4d26e7c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 9F0DB18086E21 for ; Wed, 1 Jul 2020 01:33:57 +0000 (UTC) X-HE-Tag: wren59_4b06a4d26e7c X-Filterd-Recvd-Size: 2005 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Jul 2020 01:33:57 +0000 (UTC) Received: from X1 (071-093-078-081.res.spectrum.com [71.93.78.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C79DB2074D; Wed, 1 Jul 2020 01:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593567236; bh=f1yB5Zra8JE7ZxnZ7PpU1nJ8yXL5iYPCKmc0wIacENI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tygY2kWV4JVtZg0Dh2rn7ZKNDFI5JVQoLDJUSlF2nkMO9YWjPFeiXf/CvJGCjKg8A PHTRS6pQ0OIMgj3oRBG614IePcy+t9edRW6tcaCj12Dk0svHahtq1GCl/lB9SS8B/b bjWFmRkczS/XJe2yNQTH39U7+ev2bzY0whZmQO2I= Date: Tue, 30 Jun 2020 18:33:54 -0700 From: Andrew Morton To: Matthew Wilcox Cc: Mike Kravetz , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/7] mm: Replace hpage_nr_pages with thp_nr_pages Message-Id: <20200630183354.45a8574844ae7e2cf2c9429c@linux-foundation.org> In-Reply-To: <20200629183228.GH25523@casper.infradead.org> References: <20200629151959.15779-1-willy@infradead.org> <20200629151959.15779-6-willy@infradead.org> <8bf5ae79-eace-5345-1a77-69d9e2e083b3@oracle.com> <20200629181440.GG25523@casper.infradead.org> <20200629183228.GH25523@casper.infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9F0DB18086E21 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 29 Jun 2020 19:32:28 +0100 Matthew Wilcox wrote: > So I think you found the only bug of this type, although I'm a little > unsure about the rmap_walk_file(). So... I'll assume that this part of this patch ("mm: Replace hpage_nr_pages with thp_nr_pages") is to be dropped.