From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5497EC433DF for ; Mon, 29 Jun 2020 20:24:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1BD49206A5 for ; Mon, 29 Jun 2020 20:24:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ow0w90ZC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BD49206A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 904E88D000D; Mon, 29 Jun 2020 16:24:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B41F6B00A1; Mon, 29 Jun 2020 16:24:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CA1D8D000D; Mon, 29 Jun 2020 16:24:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id 644C26B00A0 for ; Mon, 29 Jun 2020 16:24:37 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C0DAB2DFC for ; Mon, 29 Jun 2020 20:24:36 +0000 (UTC) X-FDA: 76983377352.24.roll60_3a0719126e72 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 84E641A4A7 for ; Mon, 29 Jun 2020 20:24:36 +0000 (UTC) X-HE-Tag: roll60_3a0719126e72 X-Filterd-Recvd-Size: 2604 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 29 Jun 2020 20:24:36 +0000 (UTC) Received: from kernel.org (unknown [87.71.40.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 744072067D; Mon, 29 Jun 2020 20:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593462275; bh=wEIaLX71dfGicqQIWZky1iByqXvab7v8PvlHmX+vmWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ow0w90ZCmyfal+adkRjsIQpW7g7XWqTq/MOUKtMTpPj6QkRvuUBvney2UMWoRZg+P 9FT+ytQ5jYVsJE4wvynybaWOkXYN+Rvu2RcVkggJAcvQZwwdFVWX528Qco0/BAJx8z /ul5NvzHoiwFUAWCGITz6BO3KRpf7MJs5iB8TjoU= Date: Mon, 29 Jun 2020 23:24:29 +0300 From: Mike Rapoport To: David Rientjes Cc: Su Hui , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: remove the redundancy code Message-ID: <20200629202429.GG1492837@kernel.org> References: <20200629173047.GA38128@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 84E641A4A7 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 29, 2020 at 11:50:15AM -0700, David Rientjes wrote: > On Tue, 30 Jun 2020, Su Hui wrote: > > > remove the redundancy code, the zone_start_pfn > > is assigned from zone->zone_start_pfn > > Signed-off-by: Su Hui > > I don't think this is redundant, it's used by memory hotplug when onlining > new memory. Right, it is: $ git grep -wn init_currently_empty_zone mm/memory_hotplug.c mm/memory_hotplug.c:697: init_currently_empty_zone(zone, start_pfn, nr_pages); > > --- > > mm/page_alloc.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index 3c4eb750a199..3372a8c9fbc4 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -6215,8 +6215,6 @@ void __meminit init_currently_empty_zone(struct zone *zone, > > if (zone_idx > pgdat->nr_zones) > > pgdat->nr_zones = zone_idx; > > > > - zone->zone_start_pfn = zone_start_pfn; > > - > > mminit_dprintk(MMINIT_TRACE, "memmap_init", > > "Initialising map node %d zone %lu pfns %lu -> %lu\n", > > pgdat->node_id, > -- Sincerely yours, Mike.