From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27B0EC433DF for ; Mon, 29 Jun 2020 15:53:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E73F02545F for ; Mon, 29 Jun 2020 15:53:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E73F02545F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 65D016B0082; Mon, 29 Jun 2020 11:53:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60DFD6B0083; Mon, 29 Jun 2020 11:53:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FB6E6B0085; Mon, 29 Jun 2020 11:53:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 2FE4C6B0082 for ; Mon, 29 Jun 2020 11:53:06 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C17F6824805A for ; Mon, 29 Jun 2020 15:53:05 +0000 (UTC) X-FDA: 76982693130.24.land47_3b0ef5626e70 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 9EF9C1A4A0 for ; Mon, 29 Jun 2020 15:53:05 +0000 (UTC) X-HE-Tag: land47_3b0ef5626e70 X-Filterd-Recvd-Size: 2235 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Mon, 29 Jun 2020 15:53:05 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 37EF8AD26; Mon, 29 Jun 2020 15:53:03 +0000 (UTC) Date: Mon, 29 Jun 2020 17:53:02 +0200 From: Daniel Wagner To: Dave Hansen Cc: Dave Hansen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, ben.widawsky@intel.com, alex.shi@linux.alibaba.com, tobin@kernel.org, cl@linux.com, akpm@linux-foundation.org, stable@kernel.org Subject: Re: [PATCH] mm/vmscan: restore zone_reclaim_mode ABI Message-ID: <20200629155302.6okkufqmj3kupvzw@beryllium.lan> References: <20200626003459.D8E015CA@viggo.jf.intel.com> <20200626075918.dj6ioaon5iuhtg6k@beryllium.lan> <83731eeb-1f64-50b7-41e9-5b7114678533@intel.com> <20200629071338.m4veigbp4tu45gbz@beryllium.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 9EF9C1A4A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 29, 2020 at 07:36:15AM -0700, Dave Hansen wrote: > On 6/29/20 12:13 AM, Daniel Wagner wrote: > > I went to go add a new RECLAIM_* mode for the zone_reclaim_mode > > sysctl. > > This conveys my motivation. You don't need to tell a story. As explained in the documetation 'Describe your changes', describe your change in imperative mood, e.g. something like "Add RECLAIM_* mode for the the zone_reclaim_mode sysctl." > > Like a good kernel developer, I also went to go update the > > documentation. > > This takes the opportunity to throw a tiny bit of shade in the direction > of the other folks who modified the #define without updating the > documentation. What about something simple as, "Update the documetation to match the implementation" or whatever makes it clear why you are touching the documetation bits. Anyway, I just wanted to help you to write better commit messages. I understand, my help is not welcome.