From: Daniel Wagner <dwagner@suse.de>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ben.widawsky@intel.com, alex.shi@linux.alibaba.com,
tobin@kernel.org, cl@linux.com, akpm@linux-foundation.org,
stable@kernel.org
Subject: Re: [PATCH] mm/vmscan: restore zone_reclaim_mode ABI
Date: Mon, 29 Jun 2020 17:53:02 +0200 [thread overview]
Message-ID: <20200629155302.6okkufqmj3kupvzw@beryllium.lan> (raw)
In-Reply-To: <c9a24700-7ec8-2bf8-1a13-c3ddf249a1a0@intel.com>
On Mon, Jun 29, 2020 at 07:36:15AM -0700, Dave Hansen wrote:
> On 6/29/20 12:13 AM, Daniel Wagner wrote:
> > I went to go add a new RECLAIM_* mode for the zone_reclaim_mode
> > sysctl.
>
> This conveys my motivation.
You don't need to tell a story. As explained in the documetation
'Describe your changes', describe your change in imperative mood,
e.g. something like
"Add RECLAIM_* mode for the the zone_reclaim_mode sysctl."
> > Like a good kernel developer, I also went to go update the
> > documentation.
>
> This takes the opportunity to throw a tiny bit of shade in the direction
> of the other folks who modified the #define without updating the
> documentation.
What about something simple as, "Update the documetation to
match the implementation" or whatever makes it clear why
you are touching the documetation bits.
Anyway, I just wanted to help you to write better commit
messages. I understand, my help is not welcome.
next prev parent reply other threads:[~2020-06-29 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 0:34 Dave Hansen
2020-06-26 7:59 ` Daniel Wagner
2020-06-26 13:53 ` Dave Hansen
2020-06-29 7:13 ` Daniel Wagner
2020-06-29 14:36 ` Dave Hansen
2020-06-29 15:53 ` Daniel Wagner [this message]
2020-06-29 16:05 ` Dave Hansen
[not found] ` <20200626192426.GA4329@lca.pw>
2020-06-26 21:24 ` Dave Hansen
2020-06-29 6:52 ` Baoquan He
2020-06-29 14:27 ` Dave Hansen
2020-06-29 23:30 ` Baoquan He
2020-06-29 23:37 ` Dave Hansen
2020-07-01 2:47 ` Andrew Morton
2020-07-01 15:27 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629155302.6okkufqmj3kupvzw@beryllium.lan \
--to=dwagner@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=ben.widawsky@intel.com \
--cc=cl@linux.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@kernel.org \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox