From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E267C433DF for ; Mon, 29 Jun 2020 07:13:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DDC8D2332B for ; Mon, 29 Jun 2020 07:13:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDC8D2332B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 523806B000A; Mon, 29 Jun 2020 03:13:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D34A6B000D; Mon, 29 Jun 2020 03:13:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E9D16B000E; Mon, 29 Jun 2020 03:13:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 2735C6B000A for ; Mon, 29 Jun 2020 03:13:42 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D99EE33CD for ; Mon, 29 Jun 2020 07:13:41 +0000 (UTC) X-FDA: 76981384242.21.size57_361259b26e6d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id B5DBB180442C2 for ; Mon, 29 Jun 2020 07:13:41 +0000 (UTC) X-HE-Tag: size57_361259b26e6d X-Filterd-Recvd-Size: 2331 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 29 Jun 2020 07:13:41 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EA306AF39; Mon, 29 Jun 2020 07:13:38 +0000 (UTC) Date: Mon, 29 Jun 2020 09:13:38 +0200 From: Daniel Wagner To: Dave Hansen Cc: Dave Hansen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, ben.widawsky@intel.com, alex.shi@linux.alibaba.com, tobin@kernel.org, cl@linux.com, akpm@linux-foundation.org, stable@kernel.org Subject: Re: [PATCH] mm/vmscan: restore zone_reclaim_mode ABI Message-ID: <20200629071338.m4veigbp4tu45gbz@beryllium.lan> References: <20200626003459.D8E015CA@viggo.jf.intel.com> <20200626075918.dj6ioaon5iuhtg6k@beryllium.lan> <83731eeb-1f64-50b7-41e9-5b7114678533@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83731eeb-1f64-50b7-41e9-5b7114678533@intel.com> X-Rspamd-Queue-Id: B5DBB180442C2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Dave, On Fri, Jun 26, 2020 at 06:53:33AM -0700, Dave Hansen wrote: > Was there something else specifically in the documentation which you > think I've neglected? The first paragraph explains how you ended up modifying the code. While I understand that you want to document the process, it wont help a reader in future. It doesn't add any intersting information at all. Just state what you're doing as first thing and explain why you are doing it after it. > > I think the documentation update should not be part of this patch. > > This makes the back porting to stable more difficult. > > Really? If a backporter doesn't care about documentation, I'd just > expect them to see the reject, ignore it, and move on with their life. > If they do, they'd want the code fix and the Documentation/ update in > the same patch so that they don't get disconnected. I understood you are fixing a regression ingroduced by a previous change. In this case I would only fix the regression. Updating/improving the documentation is good, I just don't think it's necessary to back port it to stables trees along side the bug fix. Thanks, Daniel