From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 264B1C433DF for ; Sat, 27 Jun 2020 17:46:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D807B2070A for ; Sat, 27 Jun 2020 17:46:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ou45Kgpm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D807B2070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 671476B0006; Sat, 27 Jun 2020 13:46:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 622116B0007; Sat, 27 Jun 2020 13:46:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 539096B0008; Sat, 27 Jun 2020 13:46:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 39C5E6B0006 for ; Sat, 27 Jun 2020 13:46:25 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 97D8D2C84 for ; Sat, 27 Jun 2020 17:46:24 +0000 (UTC) X-FDA: 76975721088.26.sand98_1411e3726e5f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 74CF91804B671 for ; Sat, 27 Jun 2020 17:46:24 +0000 (UTC) X-HE-Tag: sand98_1411e3726e5f X-Filterd-Recvd-Size: 2151 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Sat, 27 Jun 2020 17:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J6DMycn0J6mm9oSgx+xDtcS/e51KLdi0DTVUMhCfVkA=; b=ou45KgpmN+9MA37vomqLBUA3ei UUH9L9ETpov+uwrdyFU8ugSX8meH7fJ1R5uXOJBORUZYVUa6loSEUumW3lCNifHOPvqLZP5Yamyw1 dDYUIn+35rfDAmr2diHnxf29xbp9cru3L7lbkyViqlYTFjn8AA0w1RDobWZyzxUICqbKaipAZtRxw mMsLAUzDruC67oqZNA3weB5cj448sAua2G5tbIQk8OREENFffhwqfwRLvXlRrqdSsHH8B/jW8pnP/ 5u2udcdyKwMcfuyzmArHj0Q/b5Xgq1j5jv4yRH+yqWoeqP2OVo88JHX6zMCIhxeHwSLpNddlnCW8r 6okA9GoA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpEu1-0002qK-Lh; Sat, 27 Jun 2020 17:46:09 +0000 Date: Sat, 27 Jun 2020 18:46:09 +0100 From: Matthew Wilcox To: skseofh Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/page_alloc:Check pfn valid once in every page blocks Message-ID: <20200627174609.GD25039@casper.infradead.org> References: <20200627171722.GA16398@roro-Lenovo-Y520-15IKBN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200627171722.GA16398@roro-Lenovo-Y520-15IKBN> X-Rspamd-Queue-Id: 74CF91804B671 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.039756, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 28, 2020 at 02:17:22AM +0900, skseofh wrote: > Hi, all > > Please check the patch below. > Thanks:) > > > No need to check validity for every pfn in [spfn, epfn). > --- > mm/page_alloc.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) OK, so first, this is more code and added complexity. You haven't justified the extra code or complexity by giving us performance numbers. > { > - unsigned long pfn; > + unsigned long pfn, block_pfn; > u64 pgcnt = 0; > + bool in_block = 0; If something's a bool, then use 'true' and 'false', not 1 and 0.