From: Matthew Wilcox <willy@infradead.org>
To: skseofh <skseofh@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/page_alloc:Check pfn valid once in every page blocks
Date: Sat, 27 Jun 2020 18:46:09 +0100 [thread overview]
Message-ID: <20200627174609.GD25039@casper.infradead.org> (raw)
In-Reply-To: <20200627171722.GA16398@roro-Lenovo-Y520-15IKBN>
On Sun, Jun 28, 2020 at 02:17:22AM +0900, skseofh wrote:
> Hi, all
>
> Please check the patch below.
> Thanks:)
>
>
> No need to check validity for every pfn in [spfn, epfn).
> ---
> mm/page_alloc.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
OK, so first, this is more code and added complexity. You haven't justified
the extra code or complexity by giving us performance numbers.
> {
> - unsigned long pfn;
> + unsigned long pfn, block_pfn;
> u64 pgcnt = 0;
> + bool in_block = 0;
If something's a bool, then use 'true' and 'false', not 1 and 0.
prev parent reply other threads:[~2020-06-27 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 17:17 skseofh
2020-06-27 17:46 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200627174609.GD25039@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=skseofh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox