From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8929C433DF for ; Sat, 27 Jun 2020 07:57:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E0E32080C for ; Sat, 27 Jun 2020 07:57:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E0E32080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6DCF86B009B; Sat, 27 Jun 2020 03:57:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A496B009D; Sat, 27 Jun 2020 03:57:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 585276B009E; Sat, 27 Jun 2020 03:57:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3D4C36B009B for ; Sat, 27 Jun 2020 03:57:05 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 918E6181AC9C6 for ; Sat, 27 Jun 2020 07:57:04 +0000 (UTC) X-FDA: 76974235968.02.gold33_281402426e5c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 549FE100099BD47E for ; Sat, 27 Jun 2020 07:57:04 +0000 (UTC) X-HE-Tag: gold33_281402426e5c X-Filterd-Recvd-Size: 1804 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Sat, 27 Jun 2020 07:57:03 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 758DF68B02; Sat, 27 Jun 2020 09:56:59 +0200 (CEST) Date: Sat, 27 Jun 2020 09:56:59 +0200 From: Christoph Hellwig To: Ard Biesheuvel Cc: Christoph Hellwig , Andrew Morton , linux-hyperv@vger.kernel.org, Peter Zijlstra , Catalin Marinas , X86 ML , Dexuan Cui , Linux Kernel Mailing List , linux-mm@kvack.org, Jessica Yu , Vitaly Kuznetsov , Will Deacon , Linux ARM Subject: Re: [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page Message-ID: <20200627075659.GA12509@lst.de> References: <20200618064307.32739-1-hch@lst.de> <20200618064307.32739-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 549FE100099BD47E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 27, 2020 at 09:34:42AM +0200, Ard Biesheuvel wrote: > > + return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, > > + GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS, > > + NUMA_NO_NODE, __func__); > > Why is this passing a string for the 'caller' argument, and not the > address of the caller? Dementia. Fix sent.