From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AC8EC433E1 for ; Sat, 27 Jun 2020 04:55:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE10F2145D for ; Sat, 27 Jun 2020 04:55:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gsThSYYl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE10F2145D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 177906B000A; Sat, 27 Jun 2020 00:55:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 129336B002B; Sat, 27 Jun 2020 00:55:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 019A46B002D; Sat, 27 Jun 2020 00:55:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id D9E0E6B000A for ; Sat, 27 Jun 2020 00:55:18 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 476611EE6 for ; Sat, 27 Jun 2020 04:55:18 +0000 (UTC) X-FDA: 76973777916.18.bird45_2900b0226e5b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 245AA100ED3BB for ; Sat, 27 Jun 2020 04:55:18 +0000 (UTC) X-HE-Tag: bird45_2900b0226e5b X-Filterd-Recvd-Size: 4219 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Sat, 27 Jun 2020 04:55:17 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id y18so5051957plr.4 for ; Fri, 26 Jun 2020 21:55:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=+gA6TTWkMdHm5W4oJu5q0X2lUIi1w6v+kFfwKgYQFdw=; b=gsThSYYldvqlflGoCnyy6zhApgX1N1u4QndX5Ni5Ms9mflGFUYO7UxSjcngrtpUogE J0AOVFtzY1BYqTfXflC1HZBj2Gins8ECuvRTjVm3TcTy0KiiJnSliEF6E5bPN/WxTFTO icLy4DOWwVq8Dz6CJCYJum7AbZUs25BigtbQKmwIm+F7lEhWl3liPLkv4pR1w8mmlBQ8 NcPiRSr3Wot1j4JQ2BWXYRLtEurhVrSz6w5SYxdnS0EHf7lW7gSqCI0aLGlgT8TfFbcz GBMm44neagmza+5UMkSC+kE0szE5T6SZsV8f82olXxckz04SFelkGHnkDT3790KSlk14 J+rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=+gA6TTWkMdHm5W4oJu5q0X2lUIi1w6v+kFfwKgYQFdw=; b=dhLxvIa/MfHUjrwC5zm8c1kl7eHbr1+5Xow8n9GDy3xCM0Ls+rQY47Ra7KSBMtdXVG gPmyVXlgyo+NT0kgbR3le73aOZ4AVx9jI6QWEMquC4b7HqWXvr8b2uNjSoCTbL5JuvNN /jVsGkpu9nTRRYUeOsjE68EKk4fd0b6RwlOz3PT0rv8yru3FJKkWuXjJtQaH/bHCuo7o 23ze3rFgdjBh+xyV1SSDRxoyGqguyI4K3YqxuDLsj6aYCtialwJ5DmYmoQsDX7skvEEB U8ux2f4jw5fj5/avIXDXOJCg7dXmS66lcOy26CF2M10IUES3SwyVnUDbBfBu9p2c3+rs kkfw== X-Gm-Message-State: AOAM531dslL+LS2Udpf8RqCCwyMMJHud3S5ZgvYb34aYW9aAmnn8KJkb 6iwRX3l+3eesA8mpVZRmZB0= X-Google-Smtp-Source: ABdhPJx3mWKJGR86Eb7qOI9bQqp5l2FYg+gm5648darG2hlNHr2XfBF/bQlTYhbohm1zrtiHXTBoXA== X-Received: by 2002:a17:902:9a89:: with SMTP id w9mr5518433plp.30.1593233716796; Fri, 26 Jun 2020 21:55:16 -0700 (PDT) Received: from localhost ([144.34.187.180]) by smtp.gmail.com with ESMTPSA id u8sm26859976pfh.215.2020.06.26.21.55.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jun 2020 21:55:16 -0700 (PDT) Date: Sat, 27 Jun 2020 04:55:07 +0000 From: Long Li To: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v1] mm:free unused pages in kmalloc_order Message-ID: <20200627045507.GA57675@lilong> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 245AA100ED3BB X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Environment using the slub allocator, 1G memory in my ARM32. kmalloc(1024, GFP_HIGHUSER) can allocate memory normally, kmalloc(64*1024, GFP_HIGHUSER) will cause a memory leak, because alloc_pages returns highmem physical pages, but it cannot be directly converted into a virtual address and return NULL, the pages has not been released. Usually driver developers will not use the GFP_HIGHUSER flag to allocate memory in kmalloc, but I think this memory leak is not perfect, it is best to be fixed. This is the first time I have posted a patch, there may be something wrong. Signed-off-by: Long Li --- mm/slab_common.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index a143a8c8f874..d2c53b980ab3 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -819,8 +819,12 @@ void *kmalloc_order(size_t size, gfp_t flags, unsigned int order) page = alloc_pages(flags, order); if (likely(page)) { ret = page_address(page); - mod_node_page_state(page_pgdat(page), NR_SLAB_UNRECLAIMABLE_B, - PAGE_SIZE << order); + if (ret) + mod_node_page_state(page_pgdat(page), + NR_SLAB_UNRECLAIMABLE_B, + PAGE_SIZE << order); + else + __free_pages(page, order); } ret = kasan_kmalloc_large(ret, size, flags); /* As ret might get tagged, call kmemleak hook after KASAN. */ -- 2.17.1